Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the KRShaped interface in Eventing #3099

Closed
whaught opened this issue May 8, 2020 · 3 comments
Closed

Implement the KRShaped interface in Eventing #3099

whaught opened this issue May 8, 2020 · 3 comments
Assignees
Labels
area/api kind/feature-request kind/good-first-issue Denotes an issue ready for a new contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@whaught
Copy link
Contributor

whaught commented May 8, 2020

Problem
In the upstream knative.dev/pkg repo I've created a new interface that specifies accessors for resources that conform to the duckv1 shape with a duckv1.Status, objectmeta, and type meta.

https://github.com/knative/pkg/blob/66f1d63f10199087aa2aada31a07f25f516fadd0/apis/duck/v1/kresource_type.go#L30

We use this to automatically handle ObservedGeneration (and future common logic) from the generated reconciler code. This issue is to track adoption of the interface for Eventing.

Here's a model PR from serving: knative/serving#7878

Persona:
Which persona is this feature for? Contributors

Time Estimate (optional):
How many developer-days do you think this may take to resolve? 1

Additional context (optional)
This should be mostly copy-paste from the model PR and should be straightforward. However it might be a good-first-issue for someone trying to learn about our API structure.

Reporting a condition-set for Broker may have additional caveats. See: #3094

@grantr grantr added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/api kind/good-first-issue Denotes an issue ready for a new contributor. labels May 11, 2020
@whaught
Copy link
Contributor Author

whaught commented May 19, 2020

/assign

@whaught
Copy link
Contributor Author

whaught commented Jun 3, 2020

/close

@knative-prow-robot
Copy link
Contributor

@whaught: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api kind/feature-request kind/good-first-issue Denotes an issue ready for a new contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

3 participants