Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement KRShaped for serving v1 #7878

Merged
merged 13 commits into from
May 18, 2020

Conversation

whaught
Copy link
Contributor

@whaught whaught commented May 7, 2020

Issue knative/pkg#1226

Proposed Changes

  • Implements the KRShaped interface for the v1 serving resources
    • Will allow common logic in the generated reconciler

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 7, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 7, 2020
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whaught: 0 warnings.

In response to this:

Issue #1226

Proposed Changes

  • Implements the KRShaped interface for the v1 serving resources
    • Will allow common logic in the generated reconciler

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the area/API API objects and controllers label May 7, 2020
@whaught
Copy link
Contributor Author

whaught commented May 7, 2020

/assign @dprotaso

Copy link
Member

@dprotaso dprotaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue #1226 seems unrelated to this PR - what were you linking?

pkg/apis/serving/v1/configuration_types.go Outdated Show resolved Hide resolved
@knative-test-reporter-robot

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-unit-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-serving-unit-tests:

pkg/apis/serving/v1.[build failed]

@whaught whaught changed the title Implement KRShaped for serving v1 [WIP] Implement KRShaped for serving v1 May 14, 2020
@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 14, 2020
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2020
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 18, 2020
@whaught whaught changed the title [WIP] Implement KRShaped for serving v1 Implement KRShaped for serving v1 May 18, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 18, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/serving/v1/configuration_lifecycle.go 92.9% 93.3% 0.5
pkg/apis/serving/v1/configuration_types.go 0.0% 100.0% 100.0
pkg/apis/serving/v1/revision_lifecycle.go 87.2% 87.5% 0.3
pkg/apis/serving/v1/revision_types.go 0.0% 100.0% 100.0
pkg/apis/serving/v1/route_types.go 0.0% 100.0% 100.0
pkg/apis/serving/v1/service_types.go 0.0% 100.0% 100.0

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2020
@whaught
Copy link
Contributor Author

whaught commented May 18, 2020

/retest

@knative-prow-robot knative-prow-robot merged commit 99eb115 into knative:master May 18, 2020
@whaught whaught deleted the servingv1-shape branch May 18, 2020 20:43
tcnghia pushed a commit that referenced this pull request May 22, 2020
tcnghia pushed a commit that referenced this pull request May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants