Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically handle observed generation for apis/flow resources #3251

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Automatically handle observed generation for apis/flow resources #3251

merged 1 commit into from
Jun 2, 2020

Conversation

whaught
Copy link
Contributor

@whaught whaught commented Jun 2, 2020 •
edited
Loading

Issue #3099

Proposed Changes

  • Generate logic to automatically bump generation for /api/flows types

Release Note

Docs

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 2, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 2, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 2, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/flows/v1beta1/parallel_types.go Do not exist 100.0%
pkg/apis/flows/v1beta1/sequence_types.go Do not exist 100.0%
pkg/reconciler/parallel/parallel.go 69.4% 69.2% -0.3
pkg/reconciler/sequence/sequence.go 79.1% 78.9% -0.2

@whaught whaught changed the title [WIP] Automatically handle observed generation for apis/flow resources Automatically handle observed generation for apis/flow resources Jun 2, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 2, 2020
@lberk
Copy link
Member

lberk commented Jun 2, 2020

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2020
@whaught
Copy link
Contributor Author

whaught commented Jun 2, 2020

/assign @vaikas

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grantr, lberk, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2020
@knative-prow-robot knative-prow-robot merged commit f53778b into knative:master Jun 2, 2020
@whaught whaught deleted the next-bump branch June 3, 2020 15:52
@lberk lberk mentioned this pull request Sep 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grantr grantr grantr approved these changes

@slinkydeveloper slinkydeveloper Awaiting requested review from slinkydeveloper

@yolocs yolocs Awaiting requested review from yolocs

Assignees

@lberk lberk

@vaikas vaikas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@whaught @knative-metrics-robot @lberk @knative-prow-robot @grantr @googlebot @vaikas