Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing through the Broker - incoming request has a Trace ID #1756

Closed
Harwayne opened this issue Aug 28, 2019 · 3 comments
Closed

Tracing through the Broker - incoming request has a Trace ID #1756

Harwayne opened this issue Aug 28, 2019 · 3 comments
Assignees
Labels
area/observability kind/feature-request priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. proposal/0.12 Proposed (not planned) work items for 0.12 release
Milestone

Comments

@Harwayne
Copy link
Contributor

Harwayne commented Aug 28, 2019

Problem
A request made to the Broker, with a Trace ID present, should continue that trace through the Broker and via any replies.

Persona:
Event Producer

Exit Criteria
The following curl sent from inside the cluster results in a single trace that shows the Broker ingress, the underlying Channel, all the Triggers, and replies back through the Broker. It should have at least one level of replies. The trace must be viewable via Zipkin, Jaeger, or Stackdriver.

traceId=$(cat /proc/sys/kernel/random/uuid)
traceId="${traceId//-/}"

eventId=$(cat /proc/sys/kernel/random/uuid)

curl -v "http://default-broker.default.svc.cluster.local" \
  -X POST \
  -H "X-B3-Traceid: ${traceId}" \
  -H "X-B3-Spanid: ${traceId:16}" \
  -H "X-B3-Flags: 1" \
  -H "ce-specversion: 0.2" \
  -H "ce-type: ${eventType}" \
  -H "ce-time: 2018-04-05T03:56:24Z" \
  -H "ce-id: ${eventId}" \
  -H "ce-source: ${eventSource}" \
  -H 'Content-Type: application/json' \
  -d '{ "much": "wow" }'
@Harwayne Harwayne mentioned this issue Aug 29, 2019
37 tasks
@paulrossman paulrossman added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Aug 29, 2019
@Harwayne
Copy link
Contributor Author

/project Observability To do

@Harwayne
Copy link
Contributor Author

/milestone v0.10.0

@knative-prow-robot knative-prow-robot added this to the v0.10.0 milestone Sep 18, 2019
@paulrossman paulrossman modified the milestones: v0.10.0, v0.10.0-M2 Oct 3, 2019
@akashrv akashrv modified the milestones: v0.10.0-M2, v0.10.0 Oct 17, 2019
@paulrossman paulrossman modified the milestones: v0.10.0, v0.11.0-M1 Oct 30, 2019
@paulrossman paulrossman modified the milestones: v0.11.0-M1, v0.11.0-M2 Nov 21, 2019
@grantr grantr modified the milestones: v0.11.0-M2, v0.11.0 Nov 26, 2019
@vaikas vaikas added the proposal/0.12 Proposed (not planned) work items for 0.12 release label Dec 10, 2019
@vaikas vaikas modified the milestones: v0.11.0, v0.12.0 Dec 10, 2019
@akashrv akashrv modified the milestones: v0.12.0, v0.13.0 Feb 12, 2020
@paulrossman paulrossman modified the milestones: v0.13.0, v0.14.0 Mar 3, 2020
@ian-mi
Copy link
Contributor

ian-mi commented Mar 25, 2020

/close tracing conformance tests are passing for both ChannelBasedBroker and MTChannelBasedBroker

@grantr grantr closed this as completed Mar 25, 2020
skonto pushed a commit to skonto/eventing that referenced this issue Jul 8, 2022
…'s no filter (knative#6405) (knative#1756)

* Parallel to use `subscription.subscriber` instead of `reply` if there's no filter

* Unit tests for TestNewFilterSubscription

* Bolierplate

* Smoke test that parallel goes ready without any filters

* goimports

* Add comments

Co-authored-by: Ali Ok <aliok@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/observability kind/feature-request priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. proposal/0.12 Proposed (not planned) work items for 0.12 release
Projects
None yet
Development

No branches or pull requests

7 participants