Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broker tracing when incoming request has a Trace ID #6103

Closed
devguyio opened this issue Oct 24, 2019 · 4 comments
Closed

Broker tracing when incoming request has a Trace ID #6103

devguyio opened this issue Oct 24, 2019 · 4 comments
Labels
area/eventing Issues or PRs related to eventing

Comments

@devguyio
Copy link
Contributor

devguyio commented Oct 24, 2019

Description

A request made to the Broker, with a Trace ID present, should continue that trace through the Broker and via any replies.

b3 headers

Knative Issue: knative/eventing#1756

AC

  • The following curl sent from inside the cluster results in a single trace that shows the Broker ingress, the underlying Channel, all the Triggers, and replies back through the Broker. It should have at least one level of replies. The trace must be viewable via Zipkin, Jaeger, or Stackdriver.
traceId=$(cat /proc/sys/kernel/random/uuid)
traceId="${traceId//-/}"

eventId=$(cat /proc/sys/kernel/random/uuid)

curl -v "http://default-broker.default.svc.cluster.local" \
  -X POST \
  -H "X-B3-Traceid: ${traceId}" \
  -H "X-B3-Spanid: ${traceId:16}" \
  -H "X-B3-Flags: 1" \
  -H "ce-specversion: 0.2" \
  -H "ce-type: ${eventType}" \
  -H "ce-time: 2018-04-05T03:56:24Z" \
  -H "ce-id: ${eventId}" \
  -H "ce-source: ${eventSource}" \
  -H 'Content-Type: application/json' \
  -d '{ "much": "wow" }'
  • The PR is merged upstream.
@devguyio devguyio added the area/eventing Issues or PRs related to eventing label Oct 24, 2019
@devguyio devguyio modified the milestones: 1.8, Sprint_Skydiving_Tunas_5, Sprint_SkydivingTunas_6 Oct 24, 2019
@devguyio devguyio modified the milestones: Sprint_SkydivingTunas_6, Sprint_SkydivingTunas_7 Nov 11, 2019
@devguyio devguyio modified the milestones: Sprint_SkydivingTunas_7, Backlog_SkydivingTunas Nov 25, 2019
@stale
Copy link

stale bot commented Jan 24, 2020

This issue has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 24, 2020
@stale
Copy link

stale bot commented Jan 31, 2020

This issue has been automatically closed due to the lack of recent activity.

@stale stale bot closed this as completed Jan 31, 2020
@devguyio devguyio reopened this Feb 7, 2020
@stale stale bot removed the stale label Feb 7, 2020
@stale
Copy link

stale bot commented Apr 7, 2020

This issue has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 7, 2020
@stale
Copy link

stale bot commented Apr 14, 2020

This issue has been automatically closed due to the lack of recent activity.

@stale stale bot closed this as completed Apr 14, 2020
@anishj0shi anishj0shi removed the stale label Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/eventing Issues or PRs related to eventing
Projects
None yet
Development

No branches or pull requests

2 participants