Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E Test - Trace through Broker #1766

Closed
Harwayne opened this issue Aug 29, 2019 · 5 comments
Closed

E2E Test - Trace through Broker #1766

Harwayne opened this issue Aug 29, 2019 · 5 comments
Assignees
Milestone

Comments

@Harwayne
Copy link
Contributor

Harwayne commented Aug 29, 2019

Problem
Once #1708 and #1756 are finished, tracing through a Broker will work. To ensure it continues to work, we need an E2E test that verifies it.

Persona:
Contributor

Exit Criteria
A test in the e2e suite that runs before every PR merge. The test verifies that an event sent to the Broker has at least the following spans appear in the same trace:

  • Event sent to the Broker.
  • Event sent to each Trigger.
  • Event sent to each Trigger's Subscriber.
  • Any replies back from the Subscribers that are sent through the Broker again.
@Harwayne
Copy link
Contributor Author

/project Observability To do

@daisy-ycguo
Copy link
Member

Designed use case by Harwayne:

In particular, write an e2e test that sets up:

  • Broker.
  • EventSender Pod to send an event of type foo to the Broker.
  • Logger Pod + K8s Service.
    • Trigger on the Broker pointing to this Pod, filtering on event type bar.
  • Event Mutator Pod (I think this will be a new test_image) + K8s Service. This will reply with an event of type bar.
    • Trigger on the Broker pointing to this Pod, fitler on event type foo.

Then send the event, and ensure the desired number of spans are present, 11.

  • EventSender Pod to Broker Ingress.
  • Broker Ingress to Trigger Channel.
  • Trigger Channel to Trigger 1.
  • Trigger Channel to Trigger 2.
  • Trigger 1 to event mutator.
  • Trigger 1 response to Ingress Channel.
  • Ingress Channel to Broker Ingress.
  • Broker Ingress to Trigger Channel.
  • Trigger Channel to Trigger 1.
  • Trigger Channel to Trigger 2.
  • Trigger 2 to logger.

Assign myself to work on this.
/assign daisy-ycguo

@Harwayne
Copy link
Contributor Author

/milestone v0.10.0

@knative-prow-robot knative-prow-robot added this to the v0.10.0 milestone Sep 18, 2019
@akashrv akashrv modified the milestones: v0.10.0, v0.10.0-M2 Oct 4, 2019
@akashrv akashrv modified the milestones: v0.10.0-M2, v0.10.0 Oct 17, 2019
@paulrossman paulrossman modified the milestones: v0.10.0, v0.11.0-M1 Oct 30, 2019
@paulrossman paulrossman modified the milestones: v0.11.0-M1, v0.11.0-M2 Nov 21, 2019
@grantr grantr modified the milestones: v0.11.0-M2, v0.11.0 Nov 26, 2019
@vaikas vaikas added the proposal/0.12 Proposed (not planned) work items for 0.12 release label Dec 10, 2019
@akashrv akashrv modified the milestones: v0.11.0, v0.12.0 Dec 10, 2019
@akashrv akashrv added area/observability area/test-and-release Test infrastructure, tests or release labels Dec 10, 2019
@akashrv akashrv modified the milestones: v0.12.0, v0.13.0 Feb 12, 2020
@paulrossman paulrossman assigned ian-mi and unassigned Harwayne and daisy-ycguo Mar 3, 2020
@paulrossman paulrossman modified the milestones: v0.13.0, v0.14.0 Mar 3, 2020
@akashrv akashrv modified the milestones: v0.14.0, v0.15.0 Apr 14, 2020
@akashrv akashrv removed the proposal/0.12 Proposed (not planned) work items for 0.12 release label Apr 14, 2020
@grantr grantr modified the milestones: v0.15.0, v0.16.0 May 27, 2020
@grantr grantr modified the milestones: v0.16.0, v0.17.0 Jul 8, 2020
@n3wscott
Copy link
Contributor

/close

We have broker tracing tests now at ./test/conformance/broker_tracing_test.go

@knative-prow-robot
Copy link
Contributor

@n3wscott: Closing this issue.

In response to this:

/close

We have broker tracing tests now at ./test/conformance/broker_tracing_test.go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants