Correctly encoding/decoding HTML entities in search suggestions #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #458 +/- ##
=======================================
Coverage 59.48% 59.48%
=======================================
Files 50 50
Lines 3409 3409
Branches 1724 1724
=======================================
Hits 2028 2028
Misses 1378 1378
Partials 3 3 Continue to review full report at Codecov.
|
Since the `value` field of the search suggestion results is HTML escaped/encoded in the backend (see static/templates/suggestion.json) it must be decoded in the frontend.
Without this if the suggestion text contains a double quote, the response stops being a valid json.
mgautierfr
force-pushed
the
html_decoded_suggestions
branch
from
408f3aa
to
c7d7739
Compare
mgautierfr
approved these changes
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #398