Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly encoding/decoding HTML entities in search suggestions #458

Merged
merged 2 commits into from
Mar 4, 2021
Merged

Correctly encoding/decoding HTML entities in search suggestions #458

merged 2 commits into from
Mar 4, 2021

Commits on Mar 4, 2021

  1. HTML decoding of suggestions in the frontend 

    Since the `value` field of the search suggestion results is HTML
escaped/encoded in the backend (see static/templates/suggestion.json) it
must be decoded in the frontend.
    @veloman-yunkan @mgautierfr
    veloman-yunkan authored and mgautierfr committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    a7fea46 View commit details
    Browse the repository at this point in the history

  2. label field of suggestions is also HTML escaped 

    Without this if the suggestion text contains a double quote, the
response stops being a valid json.
    @veloman-yunkan @mgautierfr
    veloman-yunkan authored and mgautierfr committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    c7d7739 View commit details
    Browse the repository at this point in the history