-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kiwix-serve search is broken when video title contains an apostrophe, with TED-Ed ZIM file #143
Comments
@holta Might that be a duplicate of kiwix/libkiwix#398 ? |
@kelson42 that's really great news if PR kiwix/libkiwix#458 might have fixed this just 2 days ago. To allow for testing: will a new build of kiwix-tools (incl kiwix-serve) be published to http://download.kiwix.org/release/kiwix-tools/ including this change? |
@holta Would you be able to give a try to http://download.kiwix.org/nightly/2021-03-06/ ? At some point in the next weeks a new build/release will be published. |
It's likely fixed by http://download.kiwix.org/nightly/2021-03-06/ that I tested using http://iiab.me/kiwix/teded_en_all_2021-01/ Caveat: occasionally the search box still displayed a few of the following: (after clearing Chrome browser's cache, before relaunching the browser)
(Possibly the Chrome browser is not fully clearing its cache for pages still residual in memory.) |
Great news. FYI the new release of kiwix-tools would appear to be 45% larger (100MB instead of 69MB) which is fine, but what are the reasons if you have a moment? Or if you don't have time, ideally its new functionality/changes can be summarized here? PS Feel free to close this issue as fixed and resolved. As the above-mentioned intermittent glitches appear to have been transient as a result of the Chrome browser retaining stuff in memory (clearing a browser's cache is not quite enough!) |
Summary:
Example: https://youtu.be/dcZ0BXJYlUA is a video that is a part of the latest Kiwix TED-Ed ZIM file (teded_en_all_2021-01.zim, published 2021-01-16) as can be seen here:
http://iiab.me/kiwix/teded_en_all_2021-01/A/building_the_world_s_largest_and_most_controversial_power_plant_alex_gendler.html
Recap — users cannot search for the above video, because even after it appears in the search box's autocomplete, as follows:
But then when you try to click it, the apostophe is expanded as follows:
FYI/Context: the very latest kiwix-serve 3.1.2-4 is in use on the above-mentioned server: http://iiab.me/kiwix/teded_en_all_2021-01/
PS please move this ticket to another repo if it belongs elsewhere. Thank you.
The text was updated successfully, but these errors were encountered: