Remove vue.js #449
Remove vue.js #449
Conversation
jetownfeve21
force-pushed
the
remove-vuejs
branch
from
4d3e339
to
fb3ab3a
Compare
|
|
||
| These dependencies may or may not be packaged by your operating | ||
| system. They may also be packaged but only in an older version. The | ||
| compilation script will tell you if one of them is missing or too old. | ||
| In the worse case, you will have to download and compile bleeding edge | ||
| version by hand. | ||
|
|
||
| The [vue.js](https://vuejs.org/js/vue.js) file has to be moved in the `kiwix-desktop/resources/js` directory. This is done automatically if you use [kiwix-build](https://github.com/kiwix/kiwix-build). |
There was a problem hiding this comment.
As said in kiwix/kiwix-build#442, kiwix-desktop must not depends of kiwix-build.
kiwix-build is a "simple" tool that install dependencies before launching specific project build system. It could be replace by anything else (and this is the case for flatpak and windows).
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions. |
|
@jetownfeve21 Dou you plan to complete this PR? Or are we waiting to @mgautierfr? |
|
@kelson42 once @mgautierfr, you and I agree on what has to be done in the kiwix-build PR |
|
@jetownfeve21 Definilty, was not sure as the discussion thread was still open. |
|
Problem is not that easy to fix unfortunately and we strongly consider to use native Qt in place of the HTML rendered (what would remove the vue.js). Closing for the moment. |
Related to #230
kiwix/kiwix-build#442 has to be merged before