Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace vue.js HTML by native Qt (was: vue.js should not be part of the source code) #230

Closed
kelson42 opened this issue Aug 16, 2019 · 12 comments
Closed

Replace vue.js HTML by native Qt (was: vue.js should not be part of the source code) #230

kelson42 opened this issue Aug 16, 2019 · 12 comments
Assignees
@kelson42
Labels
duplicate enhancement

Comments

@kelson42
Copy link
Collaborator

Only our source code should be part of it. This should be downloaded at the build time.
@xurror
Copy link

xurror commented Oct 14, 2019

Do you suggest the file be removed?

@kelson42
Copy link
Collaborator Author

@xurror This is not what I have written

@xurror
Copy link

xurror commented Oct 14, 2019

Oh, I think I didn't understand the issue properly

@xurror
Copy link

xurror commented Oct 16, 2019

Only our source code should be part of it. This should be downloaded at the build time.

Please can you explain better what you mean

@stale
Copy link

stale bot commented Dec 15, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Dec 15, 2019
This was referenced May 18, 2020
Closed
Closed
@stale stale bot removed the stale label Jul 4, 2020
@kelson42 kelson42 linked a pull request Jul 4, 2020 that will close this issue
Remove vue.js #449
Closed
@stale
Copy link

stale bot commented Sep 2, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot unassigned jetownfeve21 Sep 2, 2020
@stale stale bot added the stale label Sep 2, 2020
@kelson42
Copy link
Collaborator Author

By moving the library to Qt, the problem should vanish.

@stale stale bot removed the stale label Nov 21, 2020
@kelson42
Copy link
Collaborator Author

Ticket will de facto vanish when we move the library to pure Qt.

@kelson42 kelson42 changed the title vue.js should not be part of the source code Replace vue.js HTML by native Qt (was: vue.js should not be part of the source code) Jan 16, 2021
@stale
Copy link

stale bot commented Mar 19, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Mar 19, 2021
@kelson42
Copy link
Collaborator Author

kelson42 commented Aug 28, 2021 •
edited
Loading

Closing this ticket in favour of #665

@kelson42 kelson42 self-assigned this Aug 28, 2021
@kelson42 kelson42 assigned kelson42 and unassigned kelson42 Aug 28, 2021
@mgautierfr
Copy link
Member

Closing this ticket in favour of #665

@kelson42 This is not a duplicate of #665 for me.

@kelson42
Copy link
Collaborator Author

Sorry, #683

@mgautierfr mgautierfr reopened this Aug 31, 2021
@stale stale bot removed the stale label Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kelson42 kelson42

Labels
duplicate enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove vue.js kiwix/kiwix-desktop
4 participants
@mgautierfr @kelson42 @xurror @jetownfeve21