-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Library should be rewritten in Qt #683
Comments
Is this something which will be done by official people only (thought that because its mentioned in Projects) |
@juuz0 No, I would be super glad if you could take it. This is actually the main concern I have currently with Kiwix Desktop. Obviously both @mgautierfr and me are here to guide you if needed... but this task is significantly more complex than what you have done so far. |
@kelson42 Yea, I agree this will be significantly more complex but I've the time anyway. Thanks for the assurance with mentorship too, loved working with y'all till now. I'll be starting soon, going to replicate the UI first then moving on to functionality :) |
So, I'm thinking a QTableWidget/QTableView to display the library contents. |
@juuz0 On my side, as far as it looks like and behaves like in https://github.com/kiwix/kiwix-desktop/wiki/kiwix-desktop-2-concept It is good to me. @mgautierfr more to say? |
I wonder if QML/QtQuick could be a solution here. Else, |
This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions. |
1 similar comment
This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions. |
The library is the view which allows to handle books, locally (when books are already downloaded) or remotely (from the online catalog) to download them. Here is how it looks like.
Local library (with filters):
Online library (with filters):
Although the whole Kiwix-Desktop software is written in C++, this part is a HTML rendering widget and the details are handled in HTML/JS/CSS with the framework vue.js. The problem with vue.js is that it needs a special effort to keep the visual coherence with the rest of the app in Qt. Actually there is no "real" reason why this part should not be in Qt. We should rewrite it in Qt.
Implementing this ticket is the first part of a larger effort to improve the usability of the library of Kiwix-Desktop which is currently really not good enough. See the project for a broader understanding https://github.com/kiwix/kiwix-desktop/projects/8.
The work to do is to provide something similar (maybe a few things can be changed at that time as well, but this is not the primary goall). The primary goal is to get rid of js/css/html. So, same sidebar and similar filters and on the righ pane the list of books with same features. All the core code is already in C++ in Kiwix-Desktop or Libkiwix, so this is to 90% only a UI work.
Here are the resources to have a look to:
The text was updated successfully, but these errors were encountered: