add vuejs as kiwix-desktop dependency #442
Conversation
jetownfeve21
force-pushed
the
download-vuejs
branch
2 times, most recently
from
c44a2a4
to
2234de2
Compare
jetownfeve21
force-pushed
the
download-vuejs
branch
from
2234de2
to
3755b47
Compare
There was a problem hiding this comment.
On top of the comments who are real blocker, this also need to :
- Add the dependency in
base_deps_versionsinkiwixbuild/versions.py(and updatebase_deps_meta_version - Add
vuejsas a dependency ofAllBaseDependencies(inkiwixbuild/dependencies/all_dependencies.py - Handle the flatpak build system.
| name = "vuejs" | ||
|
|
||
| class Source(Source): | ||
| archive = Remotefile('vue.js', '', 'https://vuejs.org/js/vue.js') |
There was a problem hiding this comment.
You need to file the sha256sum of the file.
|
|
||
| def _configure(self, context): | ||
| source_path = pj(neutralEnv('archive_dir'), 'vue.js') | ||
| dest_path = pj(neutralEnv('source_dir'), 'kiwix-desktop', 'resources', 'js', 'vue.js') |
There was a problem hiding this comment.
I strongly dislike this. vue.js is a dependency of kiwix-desktop, it cannot change its source directory.
We could think about kiwix-desktop copying the file in its source but :
- It would be to kiwix-desktop to do it.
- It would be to kiwix-desktop build system to do it (not kiwix-build)
- As we build "out of source", the build system must not change the source directory. I don't know how qmake can use resource in the build directory and not in the source tree.
Honestly, If this is to complex to do (we have to check on qmake side), I would say that we keep vue.js in kiwix-desktop source tree (for now at least).
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions. |
|
@jetownfeve21 Do you still plan to deal with @mgautierfr feedback? |
|
Sorry, I forgot about this ticket. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions. |
|
Problem is not that easy to fix unfortunately and we strongly consider to use native Qt in place of the HTML rendered (what would remove the vue.js). Closing for the moment. |
Related to kiwix/kiwix-desktop#230