-
Notifications
You must be signed in to change notification settings - Fork 49
Conversation
693c2d8
to
78db3bb
Compare
From testing on Packet, it seems following string must be added to the Terraform code to get things working: $ git diff
diff --git a/pkg/platform/packet/template.go b/pkg/platform/packet/template.go
index 6c7ea543..b449f8dd 100644
--- a/pkg/platform/packet/template.go
+++ b/pkg/platform/packet/template.go
@@ -287,4 +287,15 @@ output "lokomotive_values" {
value = module.packet-{{.Config.ClusterName}}.lokomotive_values
sensitive = true
}
+
+terraform {
+ required_version = ">= 0.13.0"
+
+ required_providers {
+ packet = {
+ source = "terraform-providers/packet"
+ version = "~> 2.7.3"
+ }
+ }
+}
` Note, that we render the |
ef58fd3
to
cf98394
Compare
5222ea2
to
7100402
Compare
67c66b9
to
84391ac
Compare
84391ac
to
67fdddc
Compare
Rebased to include #1021, so CI can pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest looks great
67fdddc
to
935b0b8
Compare
935b0b8
to
491affc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great
491affc
to
84549f5
Compare
The code looks ok to me, @invidian could you rebase and trigger the CI once more? |
@surajssd this is already based on latest master. I try to restart AKS job now.. |
84549f5
to
8946a7c
Compare
Well, re-pushed anyway, as CI seems to got stuck somehow |
8946a7c
to
0672a10
Compare
Restarted failed aks and packetARM pipelines |
This module does not use this provider, so it shouldn't decide on provider version to use. Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
Closes #1022 Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
Closes #788 Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
As it is more idiomatic than using Sscanf. '-json' parameter is a new option added in Terraform 0.13. Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
0672a10
to
66274b4
Compare
NOTE: Includes commits from #860.NOTE: Includes changes from #1027Closes #788
Signed-off-by: Mateusz Gozdek mateusz@kinvolk.io