This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
bootkube: feed output using local rather than local_file content #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, it seems this also causes some CI pipelines to fail, like https://yard.lokomotive-k8s.net/builds/35682. |
Currently, if one has TLS bootstrap enabled and remove it's assets directory, assuming that they use remote Terraform backend, Terraform won't be able to evalue this output, as after refreshing, local_file.bootstrap-secrets will be gone, as the file has been removed. This commit moves content rendering to local variable, so module output does not depend on local file. Closes #1016 Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
invidian
force-pushed
the
invidian/fix-assets
branch
from
430a096 to
fff55e9
Compare
|
Have you tested manually that configs are downloaded without error over the s3 backend? |
Nope, will test. |
I tested by making a copy of Terraform state file, removing entire assets directory and then copying back Terraform state file. Everything seems to work fine. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if one has TLS bootstrap enabled and remove it's assets
directory, assuming that they use remote Terraform backend, Terraform
won't be able to evalue this output, as after refreshing,
local_file.bootstrap-secrets will be gone, as the file has been removed.
This commit moves content rendering to local variable, so module output
does not depend on local file.
Closes #1016
Signed-off-by: Mateusz Gozdek mateusz@kinvolk.io