Skip to content
This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

Cleanup Terraform providers before Terraform 0.13 upgrades #860

Merged
merged 3 commits into from
Sep 28, 2020

Conversation

invidian
Copy link
Member

@invidian invidian commented Aug 26, 2020

To make migration to Terraform 0.13 easier, this PR makes some cleanups to require.tf and versions.tf files we have around to unify them, remove unused providers and add where the file is missing.

knrt10
knrt10 previously approved these changes Aug 26, 2020
Copy link
Member

@knrt10 knrt10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@invidian invidian force-pushed the invidian/pre-terraform-0-13-cleanup branch from f226373 to 5f6a4e8 Compare August 26, 2020 13:35
@invidian invidian added this to the v0.5.0 milestone Sep 4, 2020
@invidian invidian added the size/s Issues which likely require up to a couple of work hours label Sep 4, 2020
@invidian invidian removed the request for review from iaguis September 8, 2020 08:01
@invidian invidian added the kind/cleanup Cleanup issues label Sep 14, 2020
versions.tf is a standard file generated by Terraform upgrade commands,
so let's use this to make upgrades easier.

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
Following modules do not use removed providers (anymore?), so they
should require them or require their specific versions.

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
Now all files use 'required_providers' block, which is required for
Terraform 0.13 upgrade.

It also adds missing requirement on 'ct' provider for 'azure' module.

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
@invidian invidian force-pushed the invidian/pre-terraform-0-13-cleanup branch from 5f6a4e8 to c58ebcd Compare September 24, 2020 07:14
@invidian invidian requested a review from knrt10 September 28, 2020 09:51
@invidian
Copy link
Member Author

Ping @surajssd

Copy link
Member

@surajssd surajssd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@invidian invidian merged commit 35dedaf into master Sep 28, 2020
@invidian invidian deleted the invidian/pre-terraform-0-13-cleanup branch September 28, 2020 10:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/cleanup Cleanup issues size/s Issues which likely require up to a couple of work hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants