Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👥 Add codeowners #623

Merged
merged 1 commit into from
Jun 7, 2023
Merged

👥 Add codeowners #623

merged 1 commit into from
Jun 7, 2023

Conversation

znatty22
Copy link
Member

@znatty22 znatty22 commented Jun 7, 2023

  • Add a codeowners file so that we can ensure at least 1 review and approval from engineers that are familiar with the code base before merging into master branch
  • This will also help us be more cautious in deploying the QA service (happens when PRs merge into master). Caution is important here since QA is often used to test long running ETLs thus requiring coordination among teams

@znatty22 znatty22 added the devops Involves features of the deployment label Jun 7, 2023
@znatty22 znatty22 self-assigned this Jun 7, 2023
@znatty22 znatty22 merged commit 232cc46 into master Jun 7, 2023
@znatty22 znatty22 deleted the codeowners branch June 7, 2023 02:30
@calkinsh calkinsh mentioned this pull request Jul 5, 2023
calkinsh added a commit that referenced this pull request Jul 5, 2023
## Release 1.20.0

### Summary

- Emojis: ? x4, 📝 x1, 🐛 x1, 🔥 x1
- Categories: Documentation x1, Removals x1, Fixes x1, Other Changes x4

### New features and changes

- [#627](#627) -  ✨ add snRNAseq experiment strategy - [cf23ffe](cf23ffe) by [calkinsh](https://github.com/calkinsh)
- [#621](#621) -  ✨ Add Saliva Kit to SAMPLE_PROCUREMENT_ENUM for Letra - [18ad031](18ad031) by [r3m0chop](https://github.com/r3m0chop)
- [#625](#625) -  🐛 Fix port mapping in docker-compose - [634ffca](634ffca) by [znatty22](https://github.com/znatty22)
- [#614](#614) - 📝 point documentation at the kidsfirstdrc.org domain, not kids-first.io - [b080a86](b080a86) by [chris-s-friedman](https://github.com/chris-s-friedman)
- [#622](#622) - 🐛 Fix indexd POST error handling - [73755b5](73755b5) by [znatty22](https://github.com/znatty22)
- [#623](#623) -  👥 Add codeowners - [232cc46](232cc46) by [znatty22](https://github.com/znatty22)
- [#620](#620) - 🔥 Remove existing .DS_Store files and update .gitignore - [3903b98](3903b98) by [r3m0chop](https://github.com/r3m0chop)
alubneuski pushed a commit that referenced this pull request Oct 11, 2024
alubneuski pushed a commit that referenced this pull request Oct 11, 2024
## Release 1.20.0

### Summary

- Emojis: ? x4, 📝 x1, 🐛 x1, 🔥 x1
- Categories: Documentation x1, Removals x1, Fixes x1, Other Changes x4

### New features and changes

- [#627](#627) -  ✨ add snRNAseq experiment strategy - [cf23ffe](cf23ffe) by [calkinsh](https://github.com/calkinsh)
- [#621](#621) -  ✨ Add Saliva Kit to SAMPLE_PROCUREMENT_ENUM for Letra - [18ad031](18ad031) by [r3m0chop](https://github.com/r3m0chop)
- [#625](#625) -  🐛 Fix port mapping in docker-compose - [634ffca](634ffca) by [znatty22](https://github.com/znatty22)
- [#614](#614) - 📝 point documentation at the kidsfirstdrc.org domain, not kids-first.io - [b080a86](b080a86) by [chris-s-friedman](https://github.com/chris-s-friedman)
- [#622](#622) - 🐛 Fix indexd POST error handling - [73755b5](73755b5) by [znatty22](https://github.com/znatty22)
- [#623](#623) -  👥 Add codeowners - [232cc46](232cc46) by [znatty22](https://github.com/znatty22)
- [#620](#620) - 🔥 Remove existing .DS_Store files and update .gitignore - [3903b98](3903b98) by [r3m0chop](https://github.com/r3m0chop)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Involves features of the deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant