Skip to content

Commit

Permalink
Merge pull request #625 from kids-first/fix-local-server
Browse files Browse the repository at this point in the history
🐛 Fix port mapping in docker-compose
  • Loading branch information
znatty22 authored Jun 22, 2023
2 parents b080a86 + da2ba4b commit 634ffca
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
6 changes: 4 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,14 @@ development environment using 1 of 2 options:
- Con: Since everything is running in containers, need to use `docker container exec` to run things in container
- Con: You'll need to make a couple of small changes to run the dockerized service in debug mode (live updates)

1. In docker-compose.yml change the command for the dataservice container by
changing which command is commented out:
1. In docker-compose.yml change the following under the `dataservice` block:

```yaml
# command: /bin/ash -c "sleep 5; ./bin/run.sh"
command: /bin/ash -c "sleep 5; flask db upgrade; ./manage.py"

port:
- "5000:5000"
```
2. Bind host to all interfaces in manage.py:
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ services:
volumes:
- .:/app
ports:
- "5000:5000"
- "5000:80"
env_file:
- .env
environment:
Expand Down

0 comments on commit 634ffca

Please sign in to comment.