Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📝 point documentation at the kidsfirstdrc.org domain, not kids-first.io #614

Merged
merged 1 commit into from
Jun 21, 2023
Merged

📝 point documentation at the kidsfirstdrc.org domain, not kids-first.io #614

merged 1 commit into from
Jun 21, 2023

Conversation

chris-s-friedman
Copy link
Contributor

The documentation pointed to kids-first.io. Update that documentation to reference kidsfirstdrc.org

@chris-s-friedman chris-s-friedman self-assigned this May 16, 2023
@chris-s-friedman chris-s-friedman added the documentation Regarding developer or user documentation label May 16, 2023
@chris-s-friedman chris-s-friedman marked this pull request as ready for review May 16, 2023 18:40
znatty22
znatty22 requested changes May 16, 2023
View reviewed changes
Copy link
Member

@znatty22 znatty22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering why all of the urls are referring to the QA deployment. Probably should be prod? So can just remove the -qa from https://kf-api-dataservice

@chris-s-friedman chris-s-friedman requested a review from a team as a code owner June 21, 2023 15:03
@chris-s-friedman
Copy link
Contributor Author

chris-s-friedman commented Jun 21, 2023 •
edited
Loading

@znatty22 unless you feel particularly strong about it, I'm leaving the two commits separate. I see them logically different :

  1. 2cd3437 to fix the documentation to use the correct domain
  2. 1e3f627 change the documentation to reference prod instead of qa

znatty22
znatty22 approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@znatty22 znatty22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to rebase on master, and then its good to go

@chris-s-friedman
📝 point documentation at the kidsfirstdrc.org prod domain, not kids-f…
0da9ef6 
…irst.io

📝 point dataservice documentation at prod

don't point docs at qa
@chris-s-friedman chris-s-friedman force-pushed the docs/point_to_kidsfirstdrc_dot_org branch from 1e3f627 to 0da9ef6 Compare June 21, 2023 19:50
@chris-s-friedman chris-s-friedman merged commit b080a86 into master Jun 21, 2023
@chris-s-friedman chris-s-friedman deleted the docs/point_to_kidsfirstdrc_dot_org branch June 21, 2023 20:22
calkinsh added a commit that referenced this pull request Jul 5, 2023
@calkinsh
🏷️ Release 1.20.0
4a98bc1 
## Release 1.20.0

### Summary

- Emojis: ? x4, 📝 x1, 🐛 x1, 🔥 x1
- Categories: Documentation x1, Removals x1, Fixes x1, Other Changes x4

### New features and changes

- [#627](#627) -  ✨ add snRNAseq experiment strategy - [cf23ffe](cf23ffe) by [calkinsh](https://github.com/calkinsh)
- [#621](#621) -  ✨ Add Saliva Kit to SAMPLE_PROCUREMENT_ENUM for Letra - [18ad031](18ad031) by [r3m0chop](https://github.com/r3m0chop)
- [#625](#625) -  🐛 Fix port mapping in docker-compose - [634ffca](634ffca) by [znatty22](https://github.com/znatty22)
- [#614](#614) - 📝 point documentation at the kidsfirstdrc.org domain, not kids-first.io - [b080a86](b080a86) by [chris-s-friedman](https://github.com/chris-s-friedman)
- [#622](#622) - 🐛 Fix indexd POST error handling - [73755b5](73755b5) by [znatty22](https://github.com/znatty22)
- [#623](#623) -  👥 Add codeowners - [232cc46](232cc46) by [znatty22](https://github.com/znatty22)
- [#620](#620) - 🔥 Remove existing .DS_Store files and update .gitignore - [3903b98](3903b98) by [r3m0chop](https://github.com/r3m0chop)
@calkinsh calkinsh mentioned this pull request Jul 5, 2023
Merged
alubneuski pushed a commit that referenced this pull request Oct 11, 2024
@chris-s-friedman
Merge pull request #614 from kids-first/docs/point_to_kidsfirstdrc_do…
fa537a1 
…t_org

📝 point documentation at the kidsfirstdrc.org domain, not kids-first.io
alubneuski pushed a commit that referenced this pull request Oct 11, 2024
@calkinsh
🏷️ Release 1.20.0
04ad036 
## Release 1.20.0

### Summary

- Emojis: ? x4, 📝 x1, 🐛 x1, 🔥 x1
- Categories: Documentation x1, Removals x1, Fixes x1, Other Changes x4

### New features and changes

- [#627](#627) -  ✨ add snRNAseq experiment strategy - [cf23ffe](cf23ffe) by [calkinsh](https://github.com/calkinsh)
- [#621](#621) -  ✨ Add Saliva Kit to SAMPLE_PROCUREMENT_ENUM for Letra - [18ad031](18ad031) by [r3m0chop](https://github.com/r3m0chop)
- [#625](#625) -  🐛 Fix port mapping in docker-compose - [634ffca](634ffca) by [znatty22](https://github.com/znatty22)
- [#614](#614) - 📝 point documentation at the kidsfirstdrc.org domain, not kids-first.io - [b080a86](b080a86) by [chris-s-friedman](https://github.com/chris-s-friedman)
- [#622](#622) - 🐛 Fix indexd POST error handling - [73755b5](73755b5) by [znatty22](https://github.com/znatty22)
- [#623](#623) -  👥 Add codeowners - [232cc46](232cc46) by [znatty22](https://github.com/znatty22)
- [#620](#620) - 🔥 Remove existing .DS_Store files and update .gitignore - [3903b98](3903b98) by [r3m0chop](https://github.com/r3m0chop)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calkinsh calkinsh calkinsh approved these changes

@znatty22 znatty22 znatty22 approved these changes

Assignees

@chris-s-friedman chris-s-friedman

Labels
documentation Regarding developer or user documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chris-s-friedman @znatty22 @calkinsh