-
Notifications
You must be signed in to change notification settings - Fork 296
feat: Indexing configs #1018
feat: Indexing configs #1018
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1018 +/- ##
==========================================
- Coverage 40.71% 40.55% -0.17%
==========================================
Files 96 97 +1
Lines 11069 11138 +69
Branches 11069 11138 +69
==========================================
+ Hits 4507 4517 +10
- Misses 6050 6109 +59
Partials 512 512
☔ View full report in Codecov by Sentry. |
2855179
to
8dde928
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the pub fn run() -> sc_cli::Result<()>
function is getting gigantic. And heavily nested. Which is terrible for readability. Do you think you can find a way to split it into different coherent sub-functions?
Maybe by putting the body of each individual subcommand match arm in its dedicated function.
Co-authored-by: 0xevolve <Artevolve@yahoo.com>
docs/genesis.md
, if we had changes in theconfigs/genesis-assets/genesis.json
Resolves: #982
Following PR required to change:
index.json
andconstants.rs
to point to the official madara repo