Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

feat: Indexing configs #1018

Merged
merged 73 commits into from
Sep 27, 2023
Merged

Conversation

d-roak
Copy link
Collaborator

@d-roak d-roak commented Aug 18, 2023

  • pr (on close) ci commented (was not working)
  • we are now indexing the files that we retrieve online, and validating their hashes
  • ci now verifies if the hashes are correct
  • ci enforces changes in the docs/genesis.md, if we had changes in the configs/genesis-assets/genesis.json
  • documentation on our custom flags and parameters customizations
  • we have flags for disabling URL fetching
  • we have flags for retrieving/loading custom chain specs and config indexers (currently, the config indexer must have the same format as ours)

Resolves: #982

Following PR required to change: index.json and constants.rs to point to the official madara repo

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2e2d580) 40.71% compared to head (2e373c9) 40.55%.
Report is 23 commits behind head on main.

❗ Current head 2e373c9 differs from pull request most recent head 32f33e4. Consider uploading reports for the commit 32f33e4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1018      +/-   ##
==========================================
- Coverage   40.71%   40.55%   -0.17%     
==========================================
  Files          96       97       +1     
  Lines       11069    11138      +69     
  Branches    11069    11138      +69     
==========================================
+ Hits         4507     4517      +10     
- Misses       6050     6109      +59     
  Partials      512      512              
Files Coverage Δ
crates/node/src/chain_spec.rs 0.00% <ø> (ø)
crates/node/src/cli.rs 0.00% <ø> (ø)
crates/node/src/command.rs 0.00% <ø> (ø)
crates/node/src/configs.rs 0.00% <ø> (ø)
crates/node/src/main.rs 0.00% <ø> (ø)
crates/pallets/starknet/src/genesis_loader.rs 85.96% <ø> (+1.34%) ⬆️
crates/pallets/starknet/src/utils.rs 10.93% <ø> (-1.14%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d-roak d-roak marked this pull request as ready for review August 23, 2023 11:16
Copy link
Collaborator

@tdelabro tdelabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the pub fn run() -> sc_cli::Result<()> function is getting gigantic. And heavily nested. Which is terrible for readability. Do you think you can find a way to split it into different coherent sub-functions?
Maybe by putting the body of each individual subcommand match arm in its dedicated function.

.github/workflows/pull-request-close.yml Outdated Show resolved Hide resolved
crates/node/src/cli.rs Outdated Show resolved Hide resolved
crates/node/src/cli.rs Show resolved Hide resolved
crates/node/src/command.rs Outdated Show resolved Hide resolved
crates/node/src/configs.rs Outdated Show resolved Hide resolved
crates/node/src/command.rs Outdated Show resolved Hide resolved
crates/node/src/command.rs Outdated Show resolved Hide resolved
crates/node/src/command.rs Outdated Show resolved Hide resolved
@d-roak d-roak marked this pull request as ready for review September 18, 2023 02:32
CHANGELOG.md Show resolved Hide resolved
configs/index.json Show resolved Hide resolved
crates/node/src/command.rs Show resolved Hide resolved
crates/node/src/command.rs Outdated Show resolved Hide resolved
crates/node/src/command.rs Outdated Show resolved Hide resolved
crates/node/src/command.rs Outdated Show resolved Hide resolved
crates/node/src/command.rs Outdated Show resolved Hide resolved
crates/pallets/starknet/src/utils.rs Show resolved Hide resolved
crates/pallets/starknet/src/utils.rs Show resolved Hide resolved
crates/pallets/starknet/src/utils.rs Outdated Show resolved Hide resolved
crates/node/src/command.rs Outdated Show resolved Hide resolved
crates/node/src/command.rs Outdated Show resolved Hide resolved
crates/node/src/command.rs Outdated Show resolved Hide resolved
crates/node/src/command.rs Outdated Show resolved Hide resolved
crates/node/src/command.rs Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
crates/node/src/cli.rs Show resolved Hide resolved
crates/node/src/command.rs Show resolved Hide resolved
crates/node/src/command.rs Outdated Show resolved Hide resolved
@tdelabro tdelabro merged commit 97cd7de into keep-starknet-strange:main Sep 27, 2023
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Index config files and add a CI task to ensure that the CI files are correctly listed
3 participants