Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

feat: Change error types to anyhow #1129

Closed
d-roak opened this issue Sep 20, 2023 · 10 comments
Closed

feat: Change error types to anyhow #1129

d-roak opened this issue Sep 20, 2023 · 10 comments
Assignees
Labels
backlog Ready to be picked feature New feature good first issue Good for newcomers

Comments

@d-roak
Copy link
Collaborator

d-roak commented Sep 20, 2023

The true fix will be to use anyhow rather than String as the error type

Originally posted by @tdelabro in #1018 (comment)

@d-roak d-roak added good first issue Good for newcomers feature New feature labels Sep 20, 2023
@tdelabro tdelabro added the backlog Ready to be picked label Sep 20, 2023
@Immanuel-john
Copy link

hello. i would like to contribute to this. please let me know where can I start?

@tdelabro
Copy link
Collaborator

Wait for #1018 to be merged.
I think you can still look at the code, but you may need to do a huge rebase if you start a branch right now

@Immanuel-john
Copy link

@tdelabro ok i will wait for the merge then!

@d-roak
Copy link
Collaborator Author

d-roak commented Sep 27, 2023

@Immanuel-john it's merged, you can start !

@tdelabro
Copy link
Collaborator

tdelabro commented Oct 3, 2023

@Immanuel-john are you still interested to work on it?

@Immanuel-john
Copy link

hello @tdelabro i am working on it. will update ASAP!

@d-roak
Copy link
Collaborator Author

d-roak commented Oct 12, 2023

Any updates on this?

@Immanuel-john
Copy link

I tried working on this but finding difficult to get the context where I need to use anyhow. could you please help since I am a first time contributor here.

@tdelabro
Copy link
Collaborator

Hey,
It looks like it has been taken care of in #1165

@tdelabro
Copy link
Collaborator

Sorry about this it wasn't intentional.
But I think we can close this issue

@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backlog Ready to be picked feature New feature good first issue Good for newcomers
Projects
Status: Done
Development

No branches or pull requests

3 participants