Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: use official Madara image/binary #477

Closed
ftupas opened this issue Aug 24, 2023 · 1 comment
Closed

dev: use official Madara image/binary #477

ftupas opened this issue Aug 24, 2023 · 1 comment
Labels
enhancement Enhancement of the code, not introducing new features. testing Improve or add testing to the codebase
Milestone
Q4-2023 - Continu...

Comments

@ftupas
Copy link
Contributor

ftupas commented Aug 24, 2023

Describe the enhancement request

Currently, we're using a forked image of madara to run our hive tests. This allows us to load custom genesis assets i.e. hive genesis, kakarot contracts, etc. when we initialize Madara. There is this pr in Madara to enable this feature and once it's merged, we should migrate to this.

Describe Preferred Solution

Investigate and migrate to the official Madara image. Make sure that the genesis is loaded properly
@ftupas ftupas added enhancement Enhancement of the code, not introducing new features. testing Improve or add testing to the codebase labels Aug 24, 2023
@ftupas ftupas mentioned this issue Aug 25, 2023
Closed
11 tasks
@d-roak
Copy link
Contributor

d-roak commented Sep 27, 2023

Hey, we just merged the big PR, lmk (on tg) if you need help integrating it in your codebase

@Eikix Eikix closed this as completed Jan 10, 2024
anukkrit149 pushed a commit to karnotxyz/kakarot-rpc that referenced this issue Aug 9, 2024
@dragan2234
feat: test compute starknet address (kkrt-labs#506)
3782780 
<!--- Please provide a general summary of your changes in the title
above -->
Resolves kkrt-labs#477 
<!-- Give an estimate of the time you spent on this PR in terms of work
days. Did you spend 0.5 days on this PR or rather 2 days? -->

Time spent on this PR: 1.5 days

## Pull request type

<!-- Please try to limit your pull request to one type, submit multiple
pull requests if needed. -->

Please check the type of change your PR introduces:

- [ ] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, renaming)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] Documentation content changes
- [ ] Other (please describe):

## What is the current behavior?

<!-- Please describe the current behavior that you are modifying, or
link to a relevant issue. -->

Resolves #<Issue number>

## What is the new behavior?

<!-- Please describe the behavior or changes that are being added by
this PR. -->

-
-
-

## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

---------

Co-authored-by: Dragan Pilipovic <draganpilipovic@Dragans-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Enhancement of the code, not introducing new features. testing Improve or add testing to the codebase
Projects
Kakarot's Project Management
Archived in project
Milestone
Q4-2023 - Continuous Improvement - Co...
Development

Successfully merging a pull request may close this issue.

dev: update Madara genesis loading ftupas/kakarot-rpc
3 participants
@d-roak @ftupas @Eikix