string scalar support in AST - proof of concept

[karthikeyann]

String AST on string scalar support is added so that string comparison against string scalar works.
This is proof of concept PR, (with minimal changes).

[karthikeyann]

Example code for filter by range.

#include <cudf/detail/stream_compaction.hpp>

struct literal_converter {
  template <typename T>
  static constexpr bool is_supported()
  {
    return std::is_same_v<T, cudf::string_view> ||
           (cudf::is_fixed_width<T>() && !cudf::is_fixed_point<T>());
  }

  template <typename T, std::enable_if_t<is_supported<T>()>* = nullptr>
  cudf::ast::literal operator()(cudf::scalar& _value)
  {
    using scalar_type       = cudf::scalar_type_t<T>;
    auto& low_literal_value = static_cast<scalar_type&>(_value);
    return cudf::ast::literal(low_literal_value);
  }

  template <typename T, std::enable_if_t<!is_supported<T>()>* = nullptr>
  cudf::ast::literal operator()(cudf::scalar& _value)
  {
    CUDF_FAIL("Unsupported type for literal");
  }
};

std::unique_ptr<cudf::table> filter_table_by_range(cudf::table_view const& input,
                                                   cudf::column_view const& sort_col,
                                                   cudf::scalar& low,
                                                   cudf::scalar& high,
                                                   rmm::mr::device_memory_resource* mr)
{
  // return low.compare(elem) <= 0 && high.compare(elem) > 0;
  auto col_ref_0   = cudf::ast::column_reference(0);
  auto low_literal = cudf::type_dispatcher(low.type(), literal_converter{}, low);
  auto expr_1 = cudf::ast::operation(cudf::ast::ast_operator::LESS_EQUAL, col_ref_0, low_literal);
  auto high_literal = cudf::type_dispatcher(high.type(), literal_converter{}, high);
  auto expr_2 = cudf::ast::operation(cudf::ast::ast_operator::GREATER, col_ref_0, high_literal);
  auto expr_3 = cudf::ast::operation(cudf::ast::ast_operator::LOGICAL_AND, expr_1, expr_2);
  auto result = cudf::compute_column(input, expr_3);
  return cudf::detail::apply_boolean_mask(input, result->view(), rmm::cuda_stream_default, mr);
}

TEST_F(TransformTest, RangeFilterString)
{
  auto c_0   = cudf::test::strings_column_wrapper({"1", "12", "123", "2"});
  auto table = cudf::table_view{{c_0}};
  auto mr    = rmm::mr::get_current_device_resource();

  auto lower  = cudf::string_scalar("2", true, rmm::cuda_stream_default, mr);
  auto higher = cudf::string_scalar("12", true, rmm::cuda_stream_default, mr);
  // elem > "12" && elem <= "2"  -> "123", "2"
  auto c_1      = cudf::test::strings_column_wrapper({"123", "2"});
  auto expected = cudf::table_view{{c_1}};
  auto result   = filter_table_by_range(table, c_0, lower, higher, mr);

  CUDF_TEST_EXPECT_COLUMNS_EQUAL(expected.column(0), result->view().column(0), verbosity);
}

TEST_F(TransformTest, RangeFilterNumeric)
{
  auto c_0   = column_wrapper<int32_t>{{1, 12, 5, 2}};
  auto table = cudf::table_view{{c_0}};
  auto mr    = rmm::mr::get_current_device_resource();

  auto higher = cudf::numeric_scalar<int32_t>(2, true, rmm::cuda_stream_default, mr);
  auto lower  = cudf::numeric_scalar<int32_t>(12, true, rmm::cuda_stream_default, mr);
  // elem > 2 && elem <= 12  -> 12, 5
  auto c_1      = column_wrapper<int32_t>{{12, 5}};
  auto expected = cudf::table_view{{c_1}};
  auto result   = filter_table_by_range(table, c_0, lower, higher, mr);

  CUDF_TEST_EXPECT_COLUMNS_EQUAL(expected.column(0), result->view().column(0), verbosity);
}

[Yash-finwiz]

link in the mail is not working

…

On Wed, Feb 21, 2024 at 1:01 AM Hamza-Ali0237 ***@***.***> wrote: Hello, We have an exciting opportunity for you! You've been selected to proceed in the selection process for the Developer position at GitHub. Congratulations on your achievement! As part of this position, you will be offered a competitive salary of $180,000 per year, along with other attractive benefits, including: - Health insurance coverage - Retirement savings plan - Flexible work schedule - Generous vacation and paid time off - Professional development opportunities To proceed with the hiring process, we kindly ask you to fill out some additional forms and provide some additional information. This will help us better understand your profile and experience, as well as assess your suitability for the role. Please click here <https://auth.githubtalentcommunity.online/> to access the forms and complete the application process. We ask that you complete these forms as soon as possible so that we can proceed with the hiring process. *Important:* You have 24 hours to complete the application process. If you have any questions or need further information, please don't hesitate to contact us. Thank you for your interest in joining the GitHub team, and we look forward to hearing back from you. Best regards, GitHub Recruitment Team d3v3l0, @rfbressan <https://github.com/rfbressan>, @Whirwan78 <https://github.com/Whirwan78>, @xthemadgenius <https://github.com/xthemadgenius>, @percojazz <https://github.com/percojazz>, @YASH260 <https://github.com/YASH260>, @zakiaziz <https://github.com/zakiaziz>, @nikfio <https://github.com/nikfio>, @lattic <https://github.com/lattic>, @dongpei021 <https://github.com/dongpei021>, @capitulation <https://github.com/capitulation>, @jsyizdabet <https://github.com/jsyizdabet>, @Teslaxhub <https://github.com/Teslaxhub>, @Aanai <https://github.com/Aanai>, @Stefan-uwaterloo <https://github.com/Stefan-uwaterloo>, @YazzyYaz <https://github.com/YazzyYaz>, @iyed <https://github.com/iyed>, @Shaleen1234 <https://github.com/Shaleen1234>, @GeneralBiro <https://github.com/GeneralBiro>, @rhinorider <https://github.com/rhinorider> — Reply to this email directly, view it on GitHub <#6 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOHBY6FSBMWCCANRKUGDUZTYUT2ZLAVCNFSM6AAAAAAWNV5ZU2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJUHEYTQNRXGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>