Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests/identify_stream_usage.cpp #13066

Merged
merged 2 commits into from
Apr 5, 2023
Merged

Fix tests/identify_stream_usage.cpp #13066

merged 2 commits into from
Apr 5, 2023

Conversation

ahendriksen
Copy link
Contributor

Description

The identify_stream_usage test uses strcmp but not does not include <cstring>. This PR fixes that.

The missing include was surfaced by #13064, showing that the test relied on headers in spdlog to include cstring.

@ahendriksen ahendriksen requested a review from a team as a code owner April 5, 2023 12:52
@ahendriksen ahendriksen requested review from bdice and vuule April 5, 2023 12:52
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Apr 5, 2023
@ahendriksen ahendriksen mentioned this pull request Apr 5, 2023
Merged
3 tasks
bdice
bdice approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I alphabetized the includes. LGTM!

@bdice bdice added bug Something isn't working non-breaking Non-breaking change labels Apr 5, 2023
@ahendriksen
Copy link
Contributor Author

Thanks! That was quick. I thought the 'alphabetizing includes' was an automated commit.

@vuule
Copy link
Contributor

vuule commented Apr 5, 2023

/merge

@rapids-bot rapids-bot bot merged commit da7fe2a into rapidsai:branch-23.06 Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@ttnghia ttnghia ttnghia approved these changes

@vuule vuule Awaiting requested review from vuule vuule is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@ahendriksen ahendriksen

Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahendriksen @vuule @bdice @ttnghia