-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python bindings for time zone data (TZiF) reader #12826
Merged
rapids-bot
merged 11 commits into
rapidsai:branch-23.06
from
shwina:timezone-table-python-bindings
Apr 17, 2023
Merged
Add Python bindings for time zone data (TZiF) reader #12826
rapids-bot
merged 11 commits into
rapidsai:branch-23.06
from
shwina:timezone-table-python-bindings
Apr 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
CMake
CMake build issue
conda
Python
Affects Python cuDF API.
libcudf
Affects libcudf (C++/CUDA) code.
labels
Feb 22, 2023
shwina
added
non-breaking
Non-breaking change
improvement
Improvement / enhancement to an existing function
labels
Apr 7, 2023
shwina
commented
Apr 7, 2023
bdice
reviewed
Apr 7, 2023
bdice
requested changes
Apr 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a rebase because the commit history is broken but otherwise LGTM.
shwina
force-pushed
the
timezone-table-python-bindings
branch
from
April 17, 2023 12:19
de39018
to
8ec242b
Compare
bdice
approved these changes
Apr 17, 2023
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CMake
CMake build issue
improvement
Improvement / enhancement to an existing function
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
Python
Affects Python cuDF API.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds bindings to the TZiF reader that was added in the libcudf API in #12805.
No tests are being added as these bindings are just for internal-use. In follow-up PRs, I will add a timezone-aware datetime type and timezone-aware operations to the public API, along with tests for those operations.
The bindings can be used as follows:
Checklist