Fix api break #872
Merged
Fix api break #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MSeal we should merge this before releasing. |
Merged
|
sorry about introducing a breaking change @mpacer - PyCon sprints were a bit of a blur, I had |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our documentation hasn't built since #814 was merged.
This is because it broke our check_version API which is used by nbsphinx to convert notebooks to sphinx compatible documentation.
This updates that to maintain backwards compatibility (by making it an optional argument) while maintaining the new functionality.
This also adds a test for the expected functionality so we don't break APIs again.
Also this updates the docs on how to build docs and release (and makes it easier to get the doc-building dependencies with a new extra requirements flag in
setup.py).