Expose pygments styles #836
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setup_preprocessor is a contextmanager that handles setting and cleaning up attributes needed by the rest of the execution logic (specifically self.nb, self.km, self.kc). start_new_kernel was previously a callback function and is now a separate method used inside setup_preprocessor. This also introduces a dynamic default for the `kernel_name` traitlet that checks if self.nb is defined to see if it has a kernel name, and otherwise will raise an AttributeError (since that means it is being relied upon without any way to know which kernel is to be used.
moved _display_id_map help inside the declaration instead of comment unified named imports from traitlets
Feature mentioned in nteract/papermill#135 (comment)
|
I don't know why. The build only failed on python 3.3, and it did so before getting to any tests. @mpacer @takluyver |
|
Looks like it's getting a version of setuptools that doesn't support Python 3.3. There are probably ways to work around that, but I'd say we can just drop support for Python 3.3 as well. |
Changed 'ouptut' to 'output'.
Per GitHub issue #837, document the '--inplace' command line flag.
Drop support for python 3.3
I noticed that absolute paths do not work since a URL is constructed from the directory, but this was not clear from the documentation. If someone has a better wording, I'll be glad to change it. Also, this should updated in https://nbconvert.readthedocs.io/en/latest/config_options.html but the 'Edit on Github' button is broken.
Pass config to kernel from ExecutePreprocessor for configurable kernels
Update widgets CDN for ipywidgets 7 w/fallback
No input flag
Added long description to setuptools for new pypi page
Release 5.4
Release changelog 5.4
Updated release instructions based on 5.4 release walk-through
DOC: Add missing language specification to code-block
|
Crap. Sorry. I tried rebasing, because I could not build the docs because I didn't have #872. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #832
Some discussion is needed, and I'm super willing to make changes to get this PR accepted. This will let html, and latex exporting to use any pygments style, which means one can set the colors that are used to highlight code!
I also have code to let the pygments style be automatically selected from the language of the notebook. This would mean that a kernel could define a style and use the pygments plugin system allowing nbconvert to automatically select the right color scheme for the language to match what the notebook looks like. Sort of like how the appropriate lexer is already automatically chosen based on notebook metadata. That should probably be left to a future PR though.