Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 5.4 #869

Merged
merged 2 commits into from
Sep 5, 2018
Merged

Release 5.4 #869

merged 2 commits into from
Sep 5, 2018

Conversation

blink1073
Copy link
Contributor

@blink1073 blink1073 commented Aug 29, 2018

Fixes #861

@blink1073 blink1073 added this to the 5.4 milestone Aug 29, 2018
@blink1073 blink1073 changed the title Bump version and update changelog Release 5.4 Aug 29, 2018
@blink1073 blink1073 changed the title Release 5.4 [WIP] Release 5.4 Aug 29, 2018
@blink1073 blink1073 changed the title [WIP] Release 5.4 Release 5.4 Aug 30, 2018
@blink1073
Copy link
Contributor Author

@minrk, good to go?

@Carreau Carreau requested review from mpacer and MSeal August 30, 2018 18:24
Copy link
Contributor

@MSeal MSeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! A lot of people who talked to me at JupyterCon will be happy this is releasing

@MSeal
Copy link
Contributor

MSeal commented Aug 30, 2018

We hopefully can get into faster cadence for this moving forward. I'll try to get a few small items pushed for a later release (not close enough to ready for this one)

@Carreau
Copy link
Member

Carreau commented Aug 30, 2018

setup.py does not seem to have the python_requires metadata.

@Carreau
Copy link
Member

Carreau commented Aug 30, 2018

Any objection to give @MSeal push right on PyPI/conda-forge ?

@blink1073
Copy link
Contributor Author

No objections from me!

@blink1073
Copy link
Contributor Author

I'm afk, so couldn't make the python_requires change until later.

@Carreau
Copy link
Member

Carreau commented Aug 30, 2018

I'm afk, so couldn't make the python_requires change until later.

See #871

@Carreau
Copy link
Member

Carreau commented Aug 30, 2018

In which I also add the question of whether we want to drop 2.7....

@MSeal
Copy link
Contributor

MSeal commented Aug 30, 2018

Maybe with the major release so we can keep hotfix paths open in an organized manner? I think there's a lot of python 2 users still based on issues / conversations I've seen passed through papermill

@Carreau
Copy link
Member

Carreau commented Aug 30, 2018

Maybe with the major release so we can keep hotfix paths open in an organized manner

Seem like a good plan. Hopefully with the python_requires python 2 users should still get a version of nbconvert that works on their machine. We also need to keep in mind that kernels can still by python 2 as well.

@blink1073
Copy link
Contributor Author

Ready to roll. Happy to release tomorrow or defer to @MSeal.

@MSeal
Copy link
Contributor

MSeal commented Aug 31, 2018

Either way -- though I'm not on the maintainers list yet.
I'm assuming the project releases without any fancy setup calls (contributing.md doesn't specify if anything beyond bdist + sdist + twine is needed).

@Carreau
Copy link
Member

Carreau commented Aug 31, 2018

It's always a good thing to have Someone new going through the release to see if documentation is imprecise/missing :-P

@mpacer
Copy link
Member

mpacer commented Aug 31, 2018

@MSeal I can be around tomorrow online to help work through these steps. Agreed with @Carreau that it's always good to have someone new going through the release process.

I'm going to give MSeal rights on pyPI since it sounds like everyone else was on board with that.

@blink1073
Copy link
Contributor Author

Sounds good. I also created conda-forge/nbconvert-feedstock#20.

@Carreau
Copy link
Member

Carreau commented Aug 31, 2018

May want to also set description and long_description in setup.py otherwise the new PyPI page looks a bit blank.

@MSeal
Copy link
Contributor

MSeal commented Sep 1, 2018

Ahh good point -- I can make that change.

Had to have M help with #872 so I didn't get to pair on releasing today

@Carreau
Copy link
Member

Carreau commented Sep 1, 2018

Had to have M help with #872 so I didn't get to pair on releasing today

No problem and no pressure. Just trying to make high quality software, and as good wine it needs to mature :-)

@SylvainCorlay
Copy link
Member

Is there any other blocker for a release?

@MSeal
Copy link
Contributor

MSeal commented Sep 3, 2018

I need to add the description and long_description, was going to tackle it tomorrow (today is a holiday here) and see if M is around to pair on releasing.

@MSeal
Copy link
Contributor

MSeal commented Sep 4, 2018

We're putting together the changelogs -- adding some documentation notes for the next new person to run through this process.

@blink1073
Copy link
Contributor Author

This PR includes change logs

@MSeal
Copy link
Contributor

MSeal commented Sep 4, 2018

There are some late additions missing

@blink1073
Copy link
Contributor Author

Ah, just making sure you didn't go through the same pain I already did. 😉

@MSeal
Copy link
Contributor

MSeal commented Sep 5, 2018

Got caught up in work tasks today. M was helping me describe the major changes (there was a lot over the past year to categorize). Will endeavour to actually release with completed release notes tomorrow.

@Carreau
Copy link
Member

Carreau commented Sep 5, 2018

Will endeavour to actually release with completed release notes tomorrow.

It's already tomorrow. Go to sleep.

@blink1073
Copy link
Contributor Author

blink1073 commented Sep 5, 2018

Ha, what Matthias said. Thanks M and Matthew!

@Carreau
Copy link
Member

Carreau commented Sep 5, 2018

Apparently setuptools and PyPI do support

project_urls={
            "Bug Tracker": "https://bugs.example.com/HelloWorld/",
            "Documentation": "https://docs.example.com/HelloWorld/",
            "Source Code": "https://code.example.com/HelloWorld/",
        }

https://github.com/pypa/warehouse/issues/1419, https://github.com/pypa/setuptools/pull/1210

@Carreau
Copy link
Member

Carreau commented Sep 5, 2018

I pushed a short-ish long description plus a couple of other things.
Please see the latest additions.

@SylvainCorlay
Copy link
Member

The test failure comes from long_description having been added to the master branch as well.

@blink1073 @Carreau would you like to fix this? I am eager to get this in...

@Carreau
Copy link
Member

Carreau commented Sep 5, 2018 via email

@blink1073
Copy link
Contributor Author

I also won't be able to get back to this until later today.

@SylvainCorlay
Copy link
Member

Are you fine with me merging and fixing in master?

@SylvainCorlay
Copy link
Member

OK, going ahead with it :)

@SylvainCorlay SylvainCorlay merged commit b684cdd into jupyter:master Sep 5, 2018
@SylvainCorlay
Copy link
Member

Leaving it to M to tag 5.4!

@mpacer
Copy link
Member

mpacer commented Sep 5, 2018

Matt and I will take another attempt at getting this out today. We got really far for the amount of time we had to work on it yesterday. Now, it’s mostly crafting the notes about the major user-facing feature and convention changes so we can send out the announcement email.

@mpacer
Copy link
Member

mpacer commented Sep 5, 2018

In the future I’d prefer not to merge changes that break our tests on master, regardless of how urgently any of us want a feature to be released.

@SylvainCorlay
Copy link
Member

Matt and I will take another attempt at getting this out today. We got really far for the amount of time we had to work on it yesterday. Now, it’s mostly crafting the notes about the major user-facing feature and convention changes so we can send out the announcement email.

Thanks! Looking forward to it.

In the future I’d prefer not to merge changes that break our tests on master, regardless of how urgently any of us want a feature to be released.

I get it, although the required change was trivial, tested locally, and allowed us not to wait for the original PR author to rebase his PR, as he was not available.

@mpacer
Copy link
Member

mpacer commented Sep 5, 2018

@SylvainCorlay You could have pushed onto this PR rather than pushing onto master. That I would have been totally ok with :).

That's the beauty of the allow edits from maintainers option from github!

@SylvainCorlay
Copy link
Member

SylvainCorlay commented Sep 5, 2018

Yeah I wanted to do that, but the build error came from merging the branch into master where the same extra argument had already been added at a different line, so I could not have fixed it by changing this branch.

@MSeal MSeal mentioned this pull request Sep 5, 2018
@takluyver takluyver mentioned this pull request Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants