ci: fix tests in node 8 & 9 #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix nyc version to 14.1.1 when running tests in node 8 or node 9. nyc 15.x requires a version of yargs package version requires node >=10. fixes jshttp#108
|
Hey! Thanks for this. I have been tracking these down in all these repos, lol. Thanks for the help! |
wesleytodd
approved these changes
Mar 22, 2024
carpasse
added a commit
to carpasse/mime-db
that referenced
this pull request
Mar 26, 2024
Also removed Node.js version 0.6 GH fails to install it. Closes jshttp#317 Same fix as jshttp/http-errors#109
carpasse
added a commit
to carpasse/mime-db
that referenced
this pull request
Mar 26, 2024
carpasse
added a commit
to carpasse/on-finished
that referenced
this pull request
Mar 27, 2024
… action closes jshttp#48 Similar fix as jshttp/http-errors#109
carpasse
added a commit
to carpasse/on-finished
that referenced
this pull request
Mar 27, 2024
… action closes jshttp#48 Similar fix as jshttp/http-errors#109
carpasse
added a commit
to carpasse/on-finished
that referenced
this pull request
Mar 27, 2024
… action closes jshttp#48 Similar fix as jshttp/http-errors#109
carpasse
added a commit
to carpasse/on-finished
that referenced
this pull request
Mar 28, 2024
closes jshttp#48 Similar fix as jshttp/http-errors#109
carpasse
added a commit
to carpasse/on-finished
that referenced
this pull request
Mar 28, 2024
closes jshttp#48 Similar fix as jshttp/http-errors#109
carpasse
added a commit
to carpasse/statuses
that referenced
this pull request
Apr 2, 2024
UlisesGascon
pushed a commit
to jshttp/statuses
that referenced
this pull request
Apr 7, 2024
* PR: #32 * Ref: Same fix as jshttp/http-errors#109 * Fix pin versions nyc version for testing on node 8 & 9 * fix npm config on ci * add node 16 & 17 to ci tests and update node versions * add missing node versions to ci
UlisesGascon
pushed a commit
to jshttp/on-finished
that referenced
this pull request
Apr 29, 2024
PR-URL: #49 REF: #48 and jshttp/http-errors#109
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix nyc version to 14.1.1 when running tests in node 8 or node 9. nyc 15.x requires a version of yargs package version requires node >=10.
fixes #108