Fix pin versions nyc version for testing on node 8 & 9 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UlisesGascon
reviewed
Apr 2, 2024
.github/workflows/ci.yml
Outdated
Comment on lines
107
to
108
| - name: Node.js 17.x | ||
| node-version: "17.2" |
There was a problem hiding this comment.
Can we move this to a separate PR? Or include up to 21 in this one? I will suggest to keep the PR the most atomic possible and avoid add new Node.js versions in this fix.
There was a problem hiding this comment.
I will move it to a separate PR
There was a problem hiding this comment.
PR adding new versions #32
Closed
carpasse
force-pushed
the
fix/broken-tests-node-8-9
branch
from
32b57b7 to
73a2ed6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same fix as jshttp/http-errors#109
Failing build https://github.com/carpasse/statuses/actions/runs/8523124039
Build working with the fix https://github.com/carpasse/statuses/actions/runs/8523443522