Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken tests for Node@8 and Node@9 #159 #48

Closed
carpasse opened this issue Mar 27, 2024 · 1 comment · Fixed by #49
Closed

Broken tests for Node@8 and Node@9 #159 #48

carpasse opened this issue Mar 27, 2024 · 1 comment · Fixed by #49

Comments

@carpasse
Copy link
Contributor

Seems like the current master branch have some broken tests when running Node@8 and Node@9.

Issue is similar to jshttp/http-errors#109

I can not provide a failed build because the workflow is waiting for approval
Screenshot 2024-03-27 at 17 35 45
But I can see the ci-test action failing in my forked repo
https://github.com/carpasse/on-finished/actions/runs/8433556449
carpasse added a commit to carpasse/on-finished that referenced this issue Mar 27, 2024
@carpasse
update node 8 version and pin nyc. Also added missing 9.x to ci-tests…
4f85566 
… action

closes jshttp#48
Similar fix as jshttp/http-errors#109
@carpasse carpasse mentioned this issue Mar 27, 2024
Merged
carpasse added a commit to carpasse/on-finished that referenced this issue Mar 27, 2024
@carpasse
update node 8 version and pin nyc. Also added missing 9.x to ci-tests…
588707d 
… action

closes jshttp#48
Similar fix as jshttp/http-errors#109
carpasse added a commit to carpasse/on-finished that referenced this issue Mar 27, 2024
@carpasse
update node 8 version and pin nyc. Also added missing 9.x to ci-tests…
474b678 
… action

closes jshttp#48
Similar fix as jshttp/http-errors#109
@wesleytodd
Copy link
Member

I approved the PR, lets close this and just use that. Lets just wait for a bit to ensure things pass then we can merge.

carpasse added a commit to carpasse/on-finished that referenced this issue Mar 28, 2024
@carpasse
update node 8 version and pin nyc.
2a045c5 
closes jshttp#48
Similar fix as jshttp/http-errors#109
carpasse added a commit to carpasse/on-finished that referenced this issue Mar 28, 2024
@carpasse
update node 8 version and pin nyc.
12be913 
closes jshttp#48
Similar fix as jshttp/http-errors#109
UlisesGascon pushed a commit that referenced this issue Apr 29, 2024
@carpasse
ci: pin nyc in node@8 and skip node@9 (#49)
46d488f 
PR-URL: #49
REF: #48 and jshttp/http-errors#109
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update node 8 version and pin nyc. Also added missing 9.x to ci-tests… carpasse/on-finished
2 participants
@wesleytodd @carpasse