Support 1.1

[al-the-x]

Intended as a group discussion for what should still be included and released within the v1.1.x series. I've tagged a bunch of PRs and issues as "1.1" (like this one). Next steps are to actually check out the work, rebase, push the branches back, and merge them into "1.1-dev".

---

@jpfuentes2 edited this description with a list of PRs/Issues in todo format:
@koenpunt moved the todo's to #430

[al-the-x]

For consideration based on my recommendation:

• specify default ordering #75 -- specify default ORDER BY in query
• Gh49 arrayobject relations #108 (re Why are relations an array? #49) -- relations as ArrayObject
• Auto setter for relations #125 -- automatic setter for relations
• GH-68 relationship references wrong table #141 (re habtm via dual has_many through gives misleading exception #68) -- dual has_many_through references wrong table
• Add custom boolean value casting #242 -- cast to Boolean via connection
• Added method Utils::add_irregular for managing irregular names #265 -- Utils::add_irregular() to manage custom inflections
• Faster relationships #269 -- reduce complexity of relationships
• Store primary key column name in lower case #292 -- normalize primary key column names
• has_many_through and is_valid fixes #303 -- fixes has_many_through and is_valid (needs rebase)
• Move require_once out of functions? #304 -- remove require_once from functions, etc
• Implemented 'on' => 'save', 'on' => 'create' and 'on' => 'update' options for validations. #313 -- validations for "on" events
• Better Datetime handling #317 -- cast to DateTime via connection

This closes a lot of old issues and addresses some (IMO) critical bugs in the current codebase pertaining to data normalization and relations. From there, we can start looking at real enhancements.

[al-the-x]

I would also really love to know if #307 was addressed in #317 or not, since I introduced a hack in #298 to work around the "cannot reproduce" problem. @andyleap, can you confirm that you re-enabled the test I crippled in #298?

[al-the-x]

Also add:

• Added support for multiple model directories #246 (re Support for multiple model directories #163) -- multiple model directories

[andyleap]

Yes, I re-enabled the test, and it passed

[tuupola]

Really would like to see #125 -- automatic setter for relations in the official codebase. Currently running custom version of php-activerecord and it feels dirty...

[nakashu]

Well its more than a month since start of this issue.
Do we have any progress when the pull requests will be merged and 1.1 released ?

I understand that there are lot of things to do and as always time is valuable.
So is there a way how to community can help, with the integration.

Like merge and test pull request on local machines. See if they collide ?

[tuupola]

Also #133 query profiling support would be handy.

[tblanchard]

#365 would be a nice bug fix as well - when will this release happen?

[tuupola]

Also #243 Custom attributes serialization and access.

[tuupola]

@tblanchard I have a branch called kadriorg in which I have rebased and pulled many of the above. Currently #368, #365, #125, #362, #363 (which is improved version of #133), #346 and #243. I am in process of adding other pull requests too which I find useful. All tests are passing. I do not have OCI or memcache so those tests are just skipped.
If you use composer you can try the branch with something like:

{
    "repositories": [
      {
        "type": "vcs",
        "url": "https://github.com/tuupola/php-activerecord.git"
      }
    ],
    "require": {
        "php-activerecord/php-activerecord": "dev-kadriorg"
    }
}

[koenpunt]

@jpfuentes2 @al-the-x @greut How are we doing on this 1.1 release? Are there any showstoppers at the moment?

[jpfuentes2]

I am extremely busy with other obligations right now but I would like to see this project moving along. @koenpunt, I have given you commit access just now. Please do some damage. Remember:

With great power comes great responsbility.

[greut]

I'm not using PHP-AR anymore for more than one year now, sorry. AFAIK, the project is still using it happily.

[koenpunt]

@jpfuentes2 Ok thanks. Going to look into the suggested PR's above tonight.

[jpfuentes2]

@tuupola, do you have any interest in becoming a contributor as well? We could use all the help we can get! I see that you've been quite active with some great commits. Let me know!

Thanks.

[koenpunt]

#425 (#376) seems kind of intrusive, so I'll leave that out of 1.1

[koenpunt]

Same for #125 (automatic setter for relations)

[koenpunt]

Also skipping #75 (specify default ORDER BY in query) for this release, as the only implemented support is by means of @anther's scopes (#306), which is way to much overhead for now. And besides that, the code provided for scopes is not ready as is (lots of commented code, and I think not fully covered by tests as well)