has_many_through and is_valid fixes

[iazel]

has_many_through rely on other relationship to get the correct keys, but this means that every relationship of this kind must reside both in model A and model B.
An example from foo_helper:

class User extends \ActiveRecord\Model {
    static $has_many = array(
        array('user_newsletters'),
        array('newsletters', 'through' => 'user_newsletters'),
        array('active_services'),
        array('services', 'through' => 'active_services')
    );

}

class Service extends \ActiveRecord\Model {
    static $has_many = array(
        array('active_services', 'foreign_key' => 'serv_id'),
        array('users', 'through' => 'active_services')
    );
}
class ActiveService extends \ActiveRecord\Model {
    static $belongs_to = array(
        array('user'),
        array('service')
    );
}

As you can see, the foreign key in active_services is "serv_id". Then User model will use that key for joins.
Plus, is possible use this kind of relationship with "joins" option:

# code is an attribute of services
User::all( array('joins' => array('services'), 'conditions' => 'code = "daily_mail"') );

---

Model's is_valid and is_invalid have been fixed. Now they do not revalidate model at each call, but only when validation is required (ex: first time, or when an attribute has been modified). This methods accept a parameter that if true will run validations; useful only when a virtual attribute change and is used in some validations (because that can't be tracked).

---

Test included, for more information see them: HasManyThrough - Validations

[al-the-x]

Terrific work @lazel! I'm glad to see you didn't give up after all...! Look forward to reviewing these changes and merging into master.

[al-the-x]

Related to @iazel's individual PRs: #290 and #283

[iazel]

Thank you @al-the-x :) Has many through is also better than the previous request of merging, this is "smarter" :) However, digging in code, I think eager load of this kind of relationship doesn't work properly: I'll do more research when I've some other free time!

[al-the-x]

Looks like the build is failing because the scema files don't include one of your tables. Could you include that schema in your PR as well?

[iazel]

Yes, I've already updated it in my fork, but I'm still new in using github and when I've requested the merging, instead of master, I set a particular commit and I haven't found a way to change/update it ^^"

EDIT: I'm glad I was wrong: eager load work properly :)

[al-the-x]

Assigning to me to coach @iazel through sorting his Github rebasing issues...

[sweiguny]

are there any news concerning this merge requests?

[koenpunt]

Working on this: php-activerecord/Iazel-hmt-and-is_valid-fixes

[koenpunt]

Closing in favor of #464