-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for multiple model directories #246
Conversation
$model_directories = $this->get_model_directories(); | ||
return array_shift($model_directories); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OCD: remind removing the superfluous line?
Would it be too much to ask to also add a test for this change under this? |
Rebased and updated with your comments, will look into adding an additional test. |
On second thought, the test uses |
Please, if you don't mind. I would very much appreciate a test. This is a widely used library and a test can also serve the purpose of me not breaking your changes later on down the road :). |
@jpfuentes2 ping, added tests. |
how do i get these changes into my application? |
If you're using a git checkout of php-ar you can simply merge my branch ( |
ok cool thanks |
Looks like this PR supersedes #330... And there's more discussion here. |
Should definitely consider this for 1.1, since it's a long outstanding issue. |
As the title says, support for multiple model directories. Could be a solution for #163
The
set_model_directory
andget_model_directory
functions still work as they are proxied toset_model_directories
andget_model_directories
.Note, view the diff with
?w=1
, because the<CR>
's (carriage returns) are removed.