Auto setter for relations

[greut]

I've got tired of writing custom setters and came up with this, like __get it uses the relationship to auto assign a value.

What do you think?

/**
 * Auto magically link them
 */
public function __set($name, $value)
{
    $table = static::table();

    if (is_object($value) && 
        $relationship = $table->get_relationship($name)
    ) {
        $class_name = get_class($value);
        if ($relationship->class_name === $class_name) {
            $this->__relationships[$name] = $value;
            if (!$value->is_new_record()) {
                $pk = $value->get_primary_key(0);
                $name = $relationship->foreign_key[0];
                $value = $value->{$pk[0]};
            } else {
                return;
            }
        }
    }

    parent::__set($name, $value);   
}

[greut]

something similar: http://www.phpactiverecord.org/boards/1/topics/573-set-relationship

[greut]

There is it in a proper branch: https://github.com/greut/php-activerecord/compare/gh125-setter-for-relations

[jbtbnl]

Similar issue: #34

[tuupola]

This still is not in official repo? Is PHP ActiveRecord still maintained?

[anther]

+1!

[Rican7]

+1
This really needs to be added.

[Rican7]

@greut did you ever make a formal pull request based on this issue. I see that you've put it into a separate branch on your own repo and linked it here, but making a formal PR makes the issue much easier to fix/merge.

[al-the-x]

Yeah, @greut, if you could attach your branch to this issue to make it a pull request, that would really help.

[al-the-x]

If @gruet doesn't this week, I'll fetch, rebase, and open a PR for his work. This seems like a no-brainer to add, assuming there are tests, of course. ;)

[Rican7]

Just a quick note, instead of simply checking if the $value is an object, I feel like it would make more sense to check if it was an ActiveRecord Model instance:

// OLD way of doing it
if (is_object($value) && 
        $relationship = $table->get_relationship($name)
    )

...

// The new hotness
if (($value instanceof \ActiveRecord\Model) && 
        $relationship = $table->get_relationship($name)
    )

Of course you don't have to fully qualify the Model namespace if its in the Model class already. Hell, you could just use self in that case. :P

[greut]

@al-the-x be my guest, I won't have time to do that anytime soon. Thanks!

[al-the-x]

Like your suggestion, @Rican7. Let's see which of us can get to it first...! 🐎