Fixes #10217 - Review ProxyConnectionFactory buffer management. #10225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed buffer leak in ProxyConnection classes. Introduced ArrayByteBufferPool.LeakTracking to test buffer leaks. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
This was referenced Aug 4, 2023
lorban
requested changes
Aug 14, 2023
| * the {@link Buffer}s that have been leaked, which contain | ||
| * the stack trace information of where the buffer was acquired.</p> | ||
| */ | ||
| public static class LeakTracking extends ArrayByteBufferPool |
There was a problem hiding this comment.
Strictly speaking, this doesn't track leaks but acquisitions as it's up to the user of this class to know when it is safe to make leak assertions.
I'd prefer to see it renamed as it's public.
| { | ||
| private static final Logger LOG = LoggerFactory.getLogger(LeakTracking.class); | ||
|
|
||
| private final Set<Buffer> buffers = Collections.newSetFromMap(new ConcurrentHashMap<>()); |
There was a problem hiding this comment.
Suggested change
| private final Set<Buffer> buffers = Collections.newSetFromMap(new ConcurrentHashMap<>()); | |
| private final Set<Buffer> buffers = ConcurrentHashMap.newKeySet() |
| @@ -204,25 +193,36 @@ public void onFillable() | |||
| } | |||
|
|
|||
| @Override | |||
| public void onOpen() | |||
| public void onFillable() | |||
There was a problem hiding this comment.
The fact that you flipped onOpen() and onFillable()'s order makes this review unnecessarily more complex to follow, as it makes it more complex to find back the places where you added the missing release() calls.
Could you please restore their original order?
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
lorban
approved these changes
Aug 16, 2023
sbordet
deleted the
fix/jetty-12-10217-review-proxyconnectionfactory-buffers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed buffer leak in ProxyConnection classes.
Introduced ArrayByteBufferPool.LeakTracking to test buffer leaks.