New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore buffer leak tracking in tests. #10226

Closed

sbordet opened this issue Aug 4, 2023 · 3 comments

Assignees

Labels

Bug

Contributor

sbordet commented Aug 4, 2023 •

edited by lorban

Loading

Jetty version(s)
12

Description
Build on ArrayByteBufferPool.Tracking introduced in #10225 to fix the TODOs named "restore leak tracking".

The text was updated successfully, but these errors were encountered:

sbordet added the Bug label

sbordet assigned lorban

Contributor Author

sbordet commented Aug 16, 2023

See also #9148

lorban added a commit that referenced this issue


          #10226 - restore leak tracking in tests

39ae011

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban mentioned this issue

Restore leak tracking in tests #10325

Merged

lorban linked a pull request

that will close this issue

Restore leak tracking in tests #10325

Merged

lorban added a commit that referenced this issue


          #10226 - restore leak tracking in tests

75de5ff

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban added a commit that referenced this issue


          #10226 - handle review comments

ca21e9c

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban added a commit that referenced this issue


          #10226 - handle review comments

664c118

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban added a commit that referenced this issue


          #10226 - handle review comments

c78d4bb

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban added a commit that referenced this issue


          #10226 - handle review comments

1fff978

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban added a commit that referenced this issue


          #10226 - fix GZIPContentDecoder buffer leak of zero-capacity buffers

7340b0a

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban added a commit that referenced this issue


          #10226 - improve ArrayByteBufferPool.Tracking

1429cb2

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban added a commit that referenced this issue


          #10226 - assert using awaitility

86cbd15

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban added a commit that referenced this issue


          #10226 - improve TrackingBuffer dump

67bdf8d

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban added a commit that referenced this issue


          #10226 - dump the heap when a buffer leak is detected

0bf1277

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban added a commit that referenced this issue


          #10226 - improve testDownloadWithCloseMiddleOfContent debuggability b…

ef252ff

…y helping to discriminate the buffers by their content

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban added a commit that referenced this issue


          #10226 - assert using awaitility and fix heap dump cleanup when a lea…

4d0435d

…k is detected

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban added a commit that referenced this issue


          #10226 - fix dumpHeap() compilation

93fb4b3

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

olamy pushed a commit that referenced this issue


          #10226 - restore leak tracking in tests

371748b

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

olamy pushed a commit that referenced this issue


          #10226 - handle review comments

997c949

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

olamy pushed a commit that referenced this issue


          #10226 - fix GZIPContentDecoder buffer leak of zero-capacity buffers

e07db72

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

olamy pushed a commit that referenced this issue


          #10226 - improve ArrayByteBufferPool.Tracking

092ce60

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

olamy pushed a commit that referenced this issue


          #10226 - assert using awaitility

10b7fcd

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

olamy pushed a commit that referenced this issue


          #10226 - improve TrackingBuffer dump

c4798d4

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

olamy pushed a commit that referenced this issue


          #10226 - dump the heap when a buffer leak is detected

8bed967

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

olamy pushed a commit that referenced this issue


          #10226 - improve testDownloadWithCloseMiddleOfContent debuggability b…

f2832a8

…y helping to discriminate the buffers by their content

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

olamy pushed a commit that referenced this issue


          #10226 - assert using awaitility and fix heap dump cleanup when a lea…

…k is detected

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

olamy pushed a commit that referenced this issue


          #10226 - fix dumpHeap() compilation

316aaff

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban added a commit that referenced this issue


          #10226 - add ability to disable leak tracking and disable currently k…

171dbff

…nown leaky threads

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban added a commit that referenced this issue


          #10226 only fail the stream when a cause is given

9896cdc

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban added a commit that referenced this issue


          #10226 only fail the stream when a cause is given

6b4f66d

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban added a commit that referenced this issue


          #10226 release retainable buffer atomically

4ebb81b

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban added a commit that referenced this issue


          #10226 enable leak tracking

a44600e

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban added a commit that referenced this issue


          #10226 tentative: revert buffer's thread safety

fb96bb9

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban added a commit that referenced this issue


          #10226 handle review comments

5e8d34c

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban added a commit that referenced this issue


          #10226 tentative: revert buffer's thread safety

e290596

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban added a commit that referenced this issue


          #10226 enable leak tracking

ba4450f

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban added a commit that referenced this issue


          #10226 handle review comments

2f6a204

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban added a commit that referenced this issue


          #10226 release retainable buffer atomically

8519fca

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban added a commit that referenced this issue


          #10226 tentative: revert buffer's thread safety

dd3d6d7

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban added a commit that referenced this issue


          #10226 fix HTTP consumeAvailable() buffer leak and re-enable tests

499816f

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban added a commit that referenced this issue


          #10226 only release the buffer when it could not be propagated to a C…

8b3db91

…ontent.Source reader

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban added a commit that referenced this issue


          #10226 fix buffer leak in consumeAvailable() when HttpStream.consumeA…

cb68dc9

…vailable() leaves unconsumed content

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban added a commit that referenced this issue


          #10226 handle review comments

022c99c

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban added a commit that referenced this issue


          #10226 release retainable buffer atomically

43730e4

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban added a commit that referenced this issue


          #10226 tentative: revert buffer's thread safety

c4f4446

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

Contributor

lorban commented Sep 14, 2023

Leak tracking in tests has been restored, and known leaky tests have been marked with @Tag("DisableLeakTracking").

This issue can be considered solved; known leaks will be fixed independently.

lorban closed this as completed

mail731212 mentioned this issue

**Jetty version(s)** mail731212/kun731020#9

Open

lorban added a commit that referenced this issue


          Fix buffer leaks in FCGI and H3 HttpClientIdleTimeoutTest (#10432)

efc2785

#10226
- fix HttpClientIdleTimeoutTest to wait for server's idle timeout before checking for leaks
- improve HttpClientIdleTimeoutTest by making it upload some content
- fix FCGI server leak caused by idle timeout
- fix H3 server leak caused by idle timeout

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban added a commit that referenced this issue


           #10226 force completion of the handle's callback to fix a buffer leak

e7af370

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban added a commit that referenced this issue


          #10226 for releasing the buffer and failing the stream in Connection.…

dd75e74

…onClose()

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban added a commit that referenced this issue


          #10226 only fail the stream when a cause is given

f69fe95

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban added a commit that referenced this issue


          #10226 only fail the stream when a cause is given

e990b90

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban added a commit that referenced this issue


          #10226 enable leak tracking

73ff2bc

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban added a commit that referenced this issue


          #10226 handle review comments

ecda94c

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban added a commit that referenced this issue


           #10226 release retainable buffer atomically

30cd8db

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban added a commit that referenced this issue


          #10226 tentative: revert buffer's thread safety

a882927

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

lorban added a commit that referenced this issue


          #10226 Attempt at fixing FCGI buffer leak

484882b

Signed-off-by: Ludovic Orban <lorban@bitronix.be>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment