Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetty 12: leak tracking of Pool entries #9148

Closed
sbordet opened this issue Jan 10, 2023 · 2 comments · Fixed by #10787 or #10873
Closed

Jetty 12: leak tracking of Pool entries #9148

sbordet opened this issue Jan 10, 2023 · 2 comments · Fixed by #10787 or #10873
Assignees
Milestone

Comments

@sbordet
Copy link
Contributor

sbordet commented Jan 10, 2023

Jetty version(s)
12

Enhancement Description
Class Pool is now used for both ByteBuffer and client-side Connection pooling: it is much faster and better than previous implementations, but has the drawback that it is sensitive to leaking if Pool entries are not released back to the Pool.

For this reason, we need a leak detection component.
However, differently from LeakDetector (that should be removed), it cannot rely on GC because Pool always keeps a strong reference to the pooled entry.

The proposed solution is to use a time-based leak detection: if an acquired entry is not released back to the Pool within a certain period of time, or at a specific moment, then report it as leaked.

Classes to be removed:
LeakDetector
LeakTrackingByteBufferPool
LeakTrackingConnectionPool

@sbordet
Copy link
Contributor Author

sbordet commented Aug 8, 2023

See also work in #10225.

@sbordet
Copy link
Contributor Author

sbordet commented Nov 11, 2023

Fixed by #10787 and #10873.

@sbordet sbordet closed this as completed Nov 11, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Jetty 12.0.4 - FROZEN Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: ✅ Done
3 participants