-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetty 12: leak tracking of Pool entries #9148
Comments
See also work in #10225. |
github-project-automation
bot
moved this from 🏗 In progress
to ✅ Done
in Jetty 12.0.4 - FROZEN
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Jetty version(s)
12
Enhancement Description
Class
Pool
is now used for bothByteBuffer
and client-sideConnection
pooling: it is much faster and better than previous implementations, but has the drawback that it is sensitive to leaking ifPool
entries are not released back to thePool
.For this reason, we need a leak detection component.
However, differently from
LeakDetector
(that should be removed), it cannot rely on GC becausePool
always keeps a strong reference to the pooled entry.The proposed solution is to use a time-based leak detection: if an acquired entry is not released back to the
Pool
within a certain period of time, or at a specific moment, then report it as leaked.Classes to be removed:
LeakDetector
LeakTrackingByteBufferPool
LeakTrackingConnectionPool
The text was updated successfully, but these errors were encountered: