Checks API integration #180
Conversation
| System.out.println(text); | ||
| ChecksOutput output = new ChecksOutput.ChecksOutputBuilder() | ||
| .withTitle(extractChecksTitle()) | ||
| .withSummary("<sub>Send us [feedback](https://github.com/jenkinsci/junit-plugin/issues)") |
There was a problem hiding this comment.
I was wondering about maybe having a Feedback <- survey, and a bug report link, thoughts?
There was a problem hiding this comment.
Whatever works best for you. Just GitHub issues might be enough for developers, but a survey is better for common users
| System.out.println(text); | ||
| ChecksOutput output = new ChecksOutput.ChecksOutputBuilder() | ||
| .withTitle(extractChecksTitle()) | ||
| .withSummary("<sub>Send us [feedback](https://github.com/jenkinsci/junit-plugin/issues)") |
There was a problem hiding this comment.
Whatever works best for you. Just GitHub issues might be enough for developers, but a survey is better for common users
src/main/java/io/jenkins/plugins/junit/checks/JUnitChecksPublisher.java
Outdated
Show resolved
Hide resolved
src/main/java/io/jenkins/plugins/junit/checks/JUnitChecksPublisher.java
Outdated
Show resolved
Hide resolved
| builder.append("\n") | ||
| .append(summary.getFailCount() - 10) | ||
| .append(" more test results are not shown here, view them on [Jenkins](") | ||
| .append(testsURL).append(")"); |
There was a problem hiding this comment.
Does this testsURL links to the JUnit summary page? If so, I think we should use different links for here and the detailsURL, maybe just the build page links for the detailsURL?
There was a problem hiding this comment.
It links to the same place, I don’t think there’s any need to link differently the only place one would go it the test report from this check
|
Hello. |
|
the option is there and documented in https://github.com/jenkinsci/junit-plugin#test-result-checks-for-github-projects This should be discussed in jenkinsci/checks-api-plugin#38 |
|
I guess he wants to remove the status checks logs at all @timja @vladaurosh And actually, that's something we are doing now: jenkinsci/checks-api-plugin#31 |
|
skipping publishing checks will do that, (although it would be nice to have a global switch or at least at the job level to opt out of the log) |
|
Thanks @timja and @XiongKezhi . |
|
I don't get how I should configure the publisher so my results are in github. Documentation doesn't really helps me here, any help is welcome |
Fixes #160
TODO:
Example reports can be found in:
https://github.com/timja-org/junit-attachments-test/pulls
A good one is:
https://github.com/timja-org/junit-attachments-test/pull/4/checks?check_run_id=1235203424
and:
timja-org/junit-attachments-test#5