-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to allow users to customize status checks #31
Conversation
Codecov Report
@@ Coverage Diff @@
## master #31 +/- ##
============================================
- Coverage 91.20% 85.03% -6.18%
Complexity 69 69
============================================
Files 11 12 +1
Lines 273 294 +21
Branches 6 9 +3
============================================
+ Hits 249 250 +1
- Misses 22 42 +20
Partials 2 2
Continue to review full report at Codecov.
|
Added test for the implementation (jenkinsci/github-checks-plugin#66), not necessary here IMO. |
How does this allow users to suppress the log message when no checks api installation is in use? |
em... How about changing the default value of skip to be true? |
yeah I think that would fix it for the null publisher 👍, |
I'll update the implementation guide tomorrow. |
Fix docs. Co-authored-by: Tim Jacomb <timjacomb1+github@gmail.com>
Add the ability to allow users to customize status checks like name or disable the status checks feature.
The new added interface
StatusChecksProperties
share common properties between SCM implementations. Thus, the SCM implementations (like Git SCM or Branch Source SCM) can add behaviors that implement this interface to change properties of status checks.