Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to allow users to customize status checks #31

Merged
merged 12 commits into from
Oct 25, 2020

Conversation

XiongKezhi
Copy link
Contributor

@XiongKezhi XiongKezhi commented Oct 8, 2020

Add the ability to allow users to customize status checks like name or disable the status checks feature.

The new added interface StatusChecksProperties share common properties between SCM implementations. Thus, the SCM implementations (like Git SCM or Branch Source SCM) can add behaviors that implement this interface to change properties of status checks.

@XiongKezhi XiongKezhi added the enhancement New feature or request label Oct 8, 2020
@XiongKezhi XiongKezhi self-assigned this Oct 8, 2020
@XiongKezhi XiongKezhi linked an issue Oct 8, 2020 that may be closed by this pull request
pom.xml Outdated Show resolved Hide resolved
@XiongKezhi XiongKezhi requested a review from a team October 19, 2020 16:28
@XiongKezhi XiongKezhi marked this pull request as ready for review October 19, 2020 16:29
@codecov
Copy link

codecov bot commented Oct 20, 2020

Codecov Report

Merging #31 into master will decrease coverage by 6.17%.
The diff coverage is 46.15%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #31      +/-   ##
============================================
- Coverage     91.20%   85.03%   -6.18%     
  Complexity       69       69              
============================================
  Files            11       12       +1     
  Lines           273      294      +21     
  Branches          6        9       +3     
============================================
+ Hits            249      250       +1     
- Misses           22       42      +20     
  Partials          2        2              
Impacted Files Coverage Δ Complexity Δ
...gins/checks/status/BuildStatusChecksPublisher.java 34.04% <45.45%> (ø) 2.00 <2.00> (?)
.../plugins/checks/status/StatusChecksProperties.java 50.00% <50.00%> (ø) 0.00 <0.00> (?)
...ins/plugins/checks/api/ChecksPublisherFactory.java 84.21% <0.00%> (-5.27%) 8.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04f5ddc...59e556e. Read the comment docs.

@XiongKezhi XiongKezhi requested a review from timja October 21, 2020 15:38
@XiongKezhi
Copy link
Contributor Author

Added test for the implementation (jenkinsci/github-checks-plugin#66), not necessary here IMO.

@timja
Copy link
Member

timja commented Oct 21, 2020

How does this allow users to suppress the log message when no checks api installation is in use?

@XiongKezhi
Copy link
Contributor Author

How does this allow users to suppress the log message when no checks api installation is in use?

em... How about changing the default value of skip to be true?

@timja
Copy link
Member

timja commented Oct 22, 2020

How does this allow users to suppress the log message when no checks api installation is in use?

em... How about changing the default value of skip to be true?

yeah I think that would fix it for the null publisher 👍,
as long as it doesn't skip others by default

@XiongKezhi
Copy link
Contributor Author

I'll update the implementation guide tomorrow.

docs/implementation-guide.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/implementation-guide.md Outdated Show resolved Hide resolved
Fix docs.

Co-authored-by: Tim Jacomb <timjacomb1+github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants