Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow-job & workflow-cps should be in test, not compile, scope #44

Merged
merged 1 commit into from
Nov 16, 2020

Conversation

jglick
Copy link
Member

@jglick jglick commented Nov 16, 2020

Avoid unnecessary plugin dependencies. Corrects a mistake in #7.

@timja timja added the chore label Nov 16, 2020
@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #44 (39a06be) into master (ee18b95) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #44   +/-   ##
=========================================
  Coverage     85.03%   85.03%           
  Complexity       69       69           
=========================================
  Files            12       12           
  Lines           294      294           
  Branches          9        9           
=========================================
  Hits            250      250           
  Misses           42       42           
  Partials          2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee18b95...39a06be. Read the comment docs.

@jglick
Copy link
Member Author

jglick commented Nov 16, 2020

(Found because this complicates updating junit from 1.38 to 1.39 after jenkinsci/junit-plugin#180.)

@timja timja merged commit a0eff99 into jenkinsci:master Nov 16, 2020
@jglick jglick deleted the scope branch November 16, 2020 22:00
@jglick
Copy link
Member Author

jglick commented Nov 16, 2020

Thanks! Let me know when this makes it into a release.

@jglick
Copy link
Member Author

jglick commented Nov 16, 2020

https://github.com/jenkinsci/checks-api-plugin/releases/tag/v1.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants