-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advertise lambdas as arguments to then
/ runRemotely
#882
Merged
Merged
Changes from 7 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
8f2105b
`XStreamSerializable`
jglick 4bcca38
Use a `class` so that the XML representation is hidden from the API.
jglick 5a29933
Comments
jglick 2940c2f
Another Javadoc update
jglick 1f09a19
Advertise lambdas as arguments to `then` / `runRemotely`
jglick 9d2ce27
Merge branch 'master' of https://github.com/jenkinsci/jenkins-test-ha…
jglick 319a535
Clearer arrangement of test
jglick b9e40f5
Noting inner class issue; see also https://github.com/jenkinsci/jenki…
jglick 525f288
Code simplifications in `agentBuild`
jglick e302c71
Another example of a case that is more legible using lambdas
jglick e8ba58c
Using a `static` nested class from a lambda is fine
jglick d269a04
Another legible example
jglick d9040a7
Another `TestBuilder.of` example
jglick File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my experience, this is pretty difficult to assess once you experience an issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be. Noted in #881 (comment). The difference is that (anonymous) inner classes will always capture variables in lexical scope, whereas lambdas usually will not. Noted another caveat in b9e40f5.