Advertise lambdas as arguments to then / runRemotely
#882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Vlatombe
reviewed
Dec 4, 2024
| @@ -759,6 +758,15 @@ public String[] getTruststoreJavaOptions() { | |||
| * If you need to pass and/or return values, you can still use a static method reference: | |||
| * try {@link #runRemotely(Step2)} or {@link #runRemotely(StepWithReturnAndOneArg, Serializable)} etc. | |||
| * (using {@link XStreamSerializable} as needed). | |||
| * <p> | |||
| * Alternately, you could use a lambda (taking care not to capture non-serializable objects from scope): | |||
There was a problem hiding this comment.
In my experience, this is pretty difficult to assess once you experience an issue.
There was a problem hiding this comment.
Could be. Noted in #881 (comment). The difference is that (anonymous) inner classes will always capture variables in lexical scope, whereas lambdas usually will not. Noted another caveat in b9e40f5.
amuniz
approved these changes
Dec 16, 2024
Vlatombe
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More concise alternative to use of static method handles, at least for the common case that there is only one call site (or the lambda delegates to a static method with arguments). #881 (comment) for discussion (see 1f09a19)