XStreamSerializable
#881
Merged
XStreamSerializable
#881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
commented
Dec 2, 2024
jglick
commented
Dec 2, 2024
| * <li>{@code static} state cannot be shared between the top-level test code and test bodies (though the compiler will not catch this mistake). | ||
| * <li>When using a snapshot dep on Jenkins core, you must build {@code jenkins.war} to test core changes (there is no “compile-on-save” support for this). | ||
| * <li>{@link TestExtension} is not available. | ||
| * <li>{@link TestExtension} is not available (but try {@link #addSyntheticPlugin}). |
jglick
commented
Dec 2, 2024
Vlatombe
reviewed
Dec 3, 2024
Vlatombe
approved these changes
Dec 3, 2024
Vlatombe
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally a
RealJenkinsRule-based test utility needs to pass and/or return a structured object which is notSerializable. This is currently awkward; you can try to move the code to create/assert the object inside the Jenkins JVM, or find some ad-hoc way of passing it. Since XStream does not require objects to implementSerializable, and many types used in Jenkins are safe to round-trip via XML but are not markedSerializable, it is convenient to be able to work with them directly. (I considered just relaxing the signatures of the variousrunRemotelyoverloads to tolerate anyObject, and magically wrap them if not alreadySerializable, but this seemed complicated and prone to abuse. It is better to be conscious of the fact that you are serializing objects somehow.)