-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add language selection dropdown #993
Conversation
@gilgongo It just dawned on me that #988 was meant to be merged into |
Could you squash the commits down to a single commit, please. If it needs to wait for other PRs, please put this one into draft. |
@ignotus666 I'm fine with waiting if that's simpler.. but is it? |
We've two tagged bugs - gut feel is they should go in before this. |
#977 and #986 are included in this PR - they can be closed. @gilgongo after this is merged, the stuff that's for release doesn't necessarily have to wait. In fact it might be better as if by chance someone wants to add a language it won't work otherwise. @pljones yes, I'll squash all those commits when I get a chance. |
I've been doing some tests and there are going to be conflicts between this and the Weblate PR. It's caused by the changes to the po folder names and the changed language codes in the po files. I think it might be best to leave those changes for after the Weblate PR and this one are merged. Mainly to make sure the pending translations get in. If there are conflicts at a later stage for any reason Weblate can be force-reset to whatever state @gilgongo I don't know how you replaced those codes within the files, by hand or with a recursive find/replace, but on Weblate, if you change that string (e.g. "pt_PT" -> "pt-PT") in one file in a given language, that change will propagate to all other files in that language. So anyway, I'm going to revert those lang code changes for now (it only affects the po folders and files), and wait until the Weblate PR and this one have been merged before making that change. |
The check fails because some config files have the lang code changed while the po files/folders don't. This is to be expected. |
@pljones I'm having a hard time squashing all these commits; I think it's because many of them originate from other repos/branches... I'm going to open a new, clean PR. |
Short description of changes
Adds a language selection dropdown to the website. The website also detects what language the user's browser is in and initially displays itself in that language.
Scripts automating the addition of new languages have been updated to support adding the full language name + language code.
It also includes the changes from #988 and #990 so as to avoid conflicts between PRs and include all the changes here.
Context: Fixes an issue? Related issues
Fixes #977, #986 and #992
Status of this Pull Request
Should be ready pending a review.
What is missing until this pull request can be merged?
Would be good if some more people can test it.
IMPORTANT: Weblate stuff should be merged first.
Does this need translation?
No.
Checklist