Add canonical links for Google #988
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pljones
reviewed
Jun 6, 2024
pljones
reviewed
Jun 6, 2024
This doesn't seem to work locally though.
pljones
reviewed
Jun 8, 2024
pljones
reviewed
Jun 8, 2024
pljones
reviewed
Jun 8, 2024
pljones
reviewed
Jun 8, 2024
pljones
reviewed
Jun 8, 2024
Co-authored-by: Peter L Jones <pljones@users.noreply.github.com>
Co-authored-by: Peter L Jones <pljones@users.noreply.github.com>
Co-authored-by: Peter L Jones <pljones@users.noreply.github.com>
|
BTW the only way I can get the site to work without errors after cloning it locally (on Ubuntu 24.04) is to:
|
|
I had a go yesterday and surprisingly enough didn't run into any problems - the usual commands worked. I'm on Mint 21.3 (based on Ubuntu 22.04). |
|
Ok so maybe it's some ruby version dependency thing. I'll see if I can
reproduce it on a fresh 24.04 installation and maybe add a note to the docs
since the error messages are pretty unhelpful.
…On Sun, 9 Jun 2024, 12:34 pm ignotus, ***@***.***> wrote:
I had a go yesterday and surprisingly enough didn't run into any problems
- the usual commands worked. I'm on Mint 21.3 (based on Ubuntu 22.04).
—
Reply to this email directly, view it on GitHub
<#988 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABCZWU4V3EZQDBTZRGVG3WDZGQ4U3AVCNFSM6AAAAABI4NM4ICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJWGQ2TKNBXGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
pljones
reviewed
Jun 10, 2024
pljones
reviewed
Jun 10, 2024
pljones
reviewed
Jun 10, 2024
Co-authored-by: Peter L Jones <pljones@users.noreply.github.com>
pljones
reviewed
Jun 11, 2024
pljones
approved these changes
Jun 11, 2024
pljones
reviewed
Jun 11, 2024
pljones
reviewed
Jun 12, 2024
pljones
reviewed
Jun 12, 2024
pljones
reviewed
Jun 12, 2024
|
I think we may be best merging this after the language code fix is merged, since Google might treat |
This was referenced Jun 20, 2024
|
Closing as now part of #994 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
==> UPDATE <===
These changes are probably better incorporated with @ignotus666 changes to the language selector. So putting in draft for now.
Short description of changes
sitemap.xmlwhich I think might be responsible for "invalid URL" errors from Google.What is missing until this pull request can be merged?
Ideally, need to work out how to get_includes/general/nav.htmlto work, but it's not doing it when the current language is en for some reason.BTW I'm not 100% sure that adding
rel=canonicalto the EN version of links is necessarily going to fix Google's problem, since they imply we can only "suggest" the canonical versions, but hopefully this will make things a bit better.Does this need translation?
No
Checklist