Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid language codes #990

Closed
wants to merge 1 commit into from

Conversation

gilgongo
Copy link
Member

@gilgongo gilgongo commented Jun 7, 2024

==> UPDATE <===

These changes are probably better incorporated with @ignotus666 changes to the language selector. So putting in draft for now.

Short description of changes
Fixes #986

Status of this Pull Request
This seems to work OK locally.

What is missing until this pull request can be merged?
I understand we may need to look at weblate to make sure there aren't problems with it.

Does this need translation?

No (in so far as it's a structural change)

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I'm sure that this Pull Request goes to the correct branch

@gilgongo gilgongo added this to the Release 3.11.0 milestone Jun 7, 2024
@gilgongo gilgongo self-assigned this Jun 7, 2024
@gilgongo gilgongo added the bug Something isn't working label Jun 7, 2024
@gilgongo gilgongo marked this pull request as ready for review June 7, 2024 21:16
Copy link
Contributor

@ignotus666 ignotus666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it all seems to work fine for me too.

NOTE: any pending translations on Weblate need to be merged before this to avoid conflict mayhem. No guarantees it won't happen anyway but I don't think it should.

@gilgongo gilgongo mentioned this pull request Jun 13, 2024
3 tasks
@gilgongo gilgongo marked this pull request as draft June 19, 2024 11:25
@gilgongo
Copy link
Member Author

Closing as now part of #994

@gilgongo gilgongo closed this Jul 20, 2024
@pljones pljones removed this from the Release 3.11.0 milestone Jul 22, 2024
@gilgongo gilgongo deleted the lang-codes branch August 17, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants