Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(id-card): updates to application #15870

Merged
merged 126 commits into from
Sep 9, 2024
Merged

Conversation

berglindoma13
Copy link
Member

@berglindoma13 berglindoma13 commented Sep 3, 2024

...

Attach a link to issue if relevant

What

  • Made changes to the way citizenship affects application, parents with foreign citizenship need to be able to apply for children but not for themselves
  • Modified rules for age of application and screens that appear based on age
  • Made changes to rules regarding II id cards and ID id cards
  • Removed location choice
  • finished second guardian functionality
  • fixed alert messages based on which parent you are and if there are 2 parents that need to approve
  • Moved ID cards to front of radio buttons
  • Added alert when either ID card version is unavailable to the applicant
  • made price messages dynamic based on applicant
  • Modified Price choices from 12 down to 4
  • Added dataprovider for parentB

Why

Specify why you need to achieve this

Screenshots / Gifs

Attach Screenshots / Gifs to help reviewers understand the scope of the pull request

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

Summary by CodeRabbit

  • New Features

    • Enhanced validation for parents based on children's citizenship status.
    • Improved form structure for ID card applications, making it more dynamic and context-aware.
    • Added new utility functions for better applicant data handling and presentation.
    • Updated action card field types for greater flexibility and specificity.
    • Introduced dynamic messaging capabilities based on applicant details.
  • Bug Fixes

    • Corrected approval status handling for second guardian information.
  • Refactor

    • Streamlined eligibility checks and applicant information retrieval processes.
    • Improved control flow for application review processes.
  • Chores

    • Removed deprecated constants and types to enhance code clarity.

jonnigs pushed a commit that referenced this pull request Sep 12, 2024
* new application setup

* new application setup

* continued work

* stuff

* working

* State for parent B

* adding overview section to review

* confirmation, approved and rejected file

* adding steps

* AssignParentB api action

* reject application email

* adding submit application email

* commenting out fjs code in service

* adding chargefjsv2clientmodule to id card module file

* adding rest of steps

* merge conflicst

* fixing merge issues

* changes to reject conclusion screen

* ..

* accept reject buttons and modal

* fixing conclusion screen

* added disability check

* dataschema update

* klaraði bakendaföll eins og hægt er í bili

* changes in prerequisites

* changes to typeofidsubsection

* chore: charts update dirty files

* changes to condition description

* finishing up

* changing answers

* small changes

* stuff

* payment fix

* merging

* finishing too many things for one commit

* submit application

* config update

* updates

* trying stuff

* working on this

* connection type to id call

* working on this

* rest of updates for applicatin

* removed disability from dataprovider, not only with permission

* removed space

* payment codes

* temp changes, todo finish

* changes to condition for applying to id cards

* finishind touches

* small fix

* typing iddocumenttype

* fixing comments

* fixing comments

* small updates

* fixes for build

* fixes for build

* small update to test

* small update to test

* small update to test

* small update to test

* small updates

* updates to formatText, applicationCard and types

* stuff

* payment code changes

* updates to aplication

* updates to application

* more updates

* more updates

* more updates

* lokapunktar

* cosnole log remove

* more updates

* more updates

* updates after comment

---------

Co-authored-by: Sigrún Tinna Gissurardóttir <ori.sigrung@ORI0594.local>
Co-authored-by: Sigrún Tinna Gissurardóttir <sigrun.tinna.gissurardottir@origo.is>
Co-authored-by: andes-it <builders@andes.is>
Co-authored-by: Kristofer <kristofer@andes.is>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants