Change send action #1544
Merged
Change send action #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zjshen14
reviewed
Oct 14, 2019
Codecov Report
@@ Coverage Diff @@
## master #1544 +/- ##
==========================================
- Coverage 55.05% 55.02% -0.03%
==========================================
Files 149 149
Lines 13155 13157 +2
==========================================
- Hits 7242 7240 -2
- Misses 4978 4980 +2
- Partials 935 937 +2
Continue to review full report at Codecov.
|
golangcibot
reviewed
Oct 15, 2019
| @@ -302,22 +298,24 @@ func (api *Server) GetServerMeta(ctx context.Context, | |||
| } | |||
|
|
|||
| // SendAction is the API to send an action to blockchain. | |||
| func (api *Server) SendAction(ctx context.Context, in *iotexapi.SendActionRequest) (res *iotexapi.SendActionResponse, err error) { | |||
| func (api *Server) SendAction(ctx context.Context, in *iotexapi.SendActionRequest) (*iotexapi.SendActionResponse, error) { | |||
| var selp action.SealedEnvelope | ||
| var err error |
There was a problem hiding this comment.
declarations should never be cuddled (from wsl)
zjshen14
reviewed
Oct 15, 2019
zjshen14
approved these changes
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
works on #1533
I measured time consumed difference in SendAction between this change. And it turned out to be not a huge overhead even though not using dispatcher, it handles action synchronously. (2 or 3 times but microsecond unit) By this change user can directly know whether it fails to put their action into actpool or not.