API should check Gas And Balance when boardcast

[ququzone]

iotex-core/api/api.go

Line 286 in fd846ab

func (api *Server) SendAction(ctx context.Context, in *iotexapi.SendActionRequest) (res *iotexapi.SendActionResponse, err error) {

api should check Gas And Balance when broadcast, this can help caller find GasPrice, GasLimit, Balance Insufficient.

[zjshen14]

We check all these when adding an action into action pool. I think the optimization we could do is to switch the steps. We first try to put the action into local action pool, if error happens (not the pool/queue full issue), we should prevent sending the action other peers. Thoughts? cc @lizhefeng .

[zjshen14]

Per discussion offline, we should change sendAction api to:

1. Try to insert the action into local actpool
2. If success, return the success signal to indicate the action is submitted. And then relay the action to other nodes in the network.
3. If failure, return the failure signal (possibly with reason) to indicate the action isn't submitted.

[koseoyoung]

same issue with #1533
merged by PR #1544